FS#61058 - [syslinux] pkgver should reflect commits since 6.04.pre1
Attached to Project:
Arch Linux
Opened by nl6720 (nl6720) - Thursday, 13 December 2018, 12:20 GMT
Last edited by Anatol Pomozov (anatolik) - Thursday, 10 January 2019, 17:30 GMT
Opened by nl6720 (nl6720) - Thursday, 13 December 2018, 12:20 GMT
Last edited by Anatol Pomozov (anatolik) - Thursday, 10 January 2019, 17:30 GMT
|
Details
Description:
syslinux 6.04.alpha is not really syslinux 6.04.alpha (or syslinux 6.04.pre1), it's syslinux 6.04.pre1 + 41 commits on top. Other packages (e.g. flatpak 1.1.1+3+g4111dbad-1, polkit 0.115+24+g5230646-1) list the commit and the commit count since the tag. The syslinux pkgver then should be 6.04.pre1+41+g5e426532. I think something like this in pkgver() should work: git describe --long --tags | sed 's/^syslinux-//;s/-pre/.pre/;s/-/+/g' Additional info: * package version(s) * config and/or log files etc. syslinux 6.04.alpha-1 Steps to reproduce: |
This task depends upon
Closed by Anatol Pomozov (anatolik)
Thursday, 10 January 2019, 17:30 GMT
Reason for closing: Fixed
Additional comments about closing: syslinux-6.04.pre1.r41.g5e426532
Thursday, 10 January 2019, 17:30 GMT
Reason for closing: Fixed
Additional comments about closing: syslinux-6.04.pre1.r41.g5e426532
The pkgver of every gnome package in the repositories including the two you pointed out, is badly broken; see
FS#60830for more details.This reinforces my belief that packaging from git master is a bad idea.
The way I see it is, "+" is used when a specific commit is specified in the PKGBUILD and "." if it always builds from git HEAD (i.e. only AUR packages).
The "." vs. "+" is only used depending on whether you follow the battle-tested guidelines from the AUR, or the much later (and broken with respect to commit count) established style of our gnome packages once they all made the shift to building from git instead of stable releases.
git describe --long --tags | sed 's/^syslinux-//;s/-pre/.pre/;s/\([^-]*-g\)/r\1/;s/-/+/g'
expac -S '%n %v' | awk '/ .*[.+]r.*/'