FS#60985 - [lldpd] /run/lldpd is missing with 1.0.2-1

Attached to Project: Community Packages
Opened by Florian Pritz (bluewind) - Thursday, 06 December 2018, 15:38 GMT
Last edited by Christian Hesse (eworm) - Friday, 07 December 2018, 12:27 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Christian Hesse (eworm)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I see that you switched from our systemd files to the upstream files, but it looks like the tmpfiles file is not part of upstream. Without that I don't appear to get the /run/lldpd directory and lldpd fails to start:

Dec 06 16:06:43 pearl systemd[1]: Starting LLDP daemon...
Dec 06 16:06:45 pearl lldpd[1505]: unable to create control socket at /run/lldpd/socket: No such file or directory
Dec 06 16:06:45 pearl lldpd[1505]: giving up
Dec 06 16:06:46 pearl systemd[1]: lldpd.service: Main process exited, code=exited, status=1/FAILURE
Dec 06 16:06:46 pearl systemd[1]: lldpd.service: Failed with result 'exit-code'.

pwck also complains about the missing directory:
> pwck
user 'lldpd': directory '/run/lldpd' does not exist


I'm not sure why it is missing. Any ideas how to best fix this?

lldpd 1.0.2-1
This task depends upon

Closed by  Christian Hesse (eworm)
Friday, 07 December 2018, 12:27 GMT
Reason for closing:  Fixed
Additional comments about closing:  lldpd 1.0.2-2
Comment by Christian Hesse (eworm) - Friday, 07 December 2018, 08:47 GMT
Hmm, I tested the package and it worked... Wondering whether an old version was installed before and directory was still in place.
Comment by Christian Hesse (eworm) - Friday, 07 December 2018, 08:49 GMT
Oh, I did the change with lldpd 1.0.1-3... Did that work for you?
Comment by Christian Hesse (eworm) - Friday, 07 December 2018, 08:54 GMT
I guess it broke here...
https://github.com/vincentbernat/lldpd/commit/90a50860ebdcdeb5b7dc85790b18bed23c97ec32
Comment by Florian Pritz (bluewind) - Friday, 07 December 2018, 09:38 GMT
I didn't use 1.0.1-3 before, but I tested it now and it works, yes. That mkdir creates /run/lldpd/chroot and all parts of the path so it also creates /run/lldpd. I'm guessing that the chroot code in the binary itself is only run when you actually use it so it probably doesn't execute any more or it may execute later. I guess it's probably best to bring the tempfiles file back, right?
Comment by Christian Hesse (eworm) - Friday, 07 December 2018, 09:40 GMT
Just working to bring the tmpfiles file upstream...
(/me hates build system hacking...)
Comment by Christian Hesse (eworm) - Friday, 07 December 2018, 12:07 GMT
Let's see if this will be merged...
https://github.com/vincentbernat/lldpd/pull/311

Loading...