FS#60827 - [scantailor] New version contains several regressions and is not backwards compatible

Attached to Project: Community Packages
Opened by alexander raban (alraban) - Friday, 16 November 2018, 17:03 GMT
Last edited by Sergej Pupykin (sergej) - Thursday, 29 November 2018, 09:38 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

The scantailor package was recently updated to 0.9.12.2-3 from 0.9.12.2-1. The new version no longer correctly reads the project files created by the prior version of scantailor (i.e. content selections and margins are broken, among other things). This is a breaking change, which was unexpected in a pkgver bump. I have close to a thousand scantailor project files. The new version also no longer appears to support graphical acceleration or multithreaded processing, which is not breaking, but significantly reduces the usability of the program (jobs now take more than eight times longer to process).

Additional info:

Package version 0.9.12.2-3 introduced this issue and rolling back solves it (the prior version works fine). There appears to be no upstream activity that would have caused this at the repo listed in the PKGBUILD (git://github.com/Tulon/scantailor.git), so it seems like these issues may be related to the new build patches included with the new version?

Steps to reproduce:

Create a project file in scantailor 0.9.12.2-1, then attempt to process it in 0.9.12.2-3
This task depends upon

Closed by  Sergej Pupykin (sergej)
Thursday, 29 November 2018, 09:38 GMT
Reason for closing:  Fixed
Comment by Sergej Pupykin (sergej) - Monday, 26 November 2018, 16:46 GMT
it is strange, it mostly adds "boost::lambda::" so compiler can find identifiers. Patch is similar to https://src.fedoraproject.org/rpms/scantailor/blob/master/f/boost1.6.patch
Comment by alexander raban (alraban) - Monday, 26 November 2018, 23:50 GMT
I think the fedora scantailor is using a different upstream for scantailor, I'm not sure if that makes a difference.

It looks like Fedora is using the original repo which is mostly unmaintained: https://github.com/scantailor/scantailor

The Arch package had been using the experimental builds forked from the original scantailor by the original author (Tulon), found here: git://github.com/Tulon/scantailor.git. He did a lot of feature work in 2016, including some of the features that are now missing from the new build (like openCL acceleration), and changing the margins from mm to %, etc.

Did the new build change upstreams, or inadvertently revert to an older release/commit on Tulon's repo? That would explain the sudden loss of features and project file compatibility.
Comment by Matt (madalu) - Wednesday, 28 November 2018, 19:30 GMT
I can confirm that content selection and margins are broken in the 0.9.12.2-3. Downgrading to 0.9.12.2-1 solves all issues.
Comment by Matt (madalu) - Wednesday, 28 November 2018, 20:36 GMT
Apart from the patch, the big difference I can see in the PKGBUILD is that 0.9.12.2-1 and earlier used to download an experimental build (https://github.com/Tulon/scantailor/releases/tag/EXPERIMENTAL_2015_10_27). By contrast, pkgver 0.9.12.2-3 checks out "master" which is missing many of the commits contained in the experimental build. So the recent pgkver upgrade actually reverted to an earlier version of the software, which probably explains some of the regressions we're seeing.
Comment by Sergej Pupykin (sergej) - Wednesday, 28 November 2018, 21:09 GMT
Please try scantailor-0.9.12.2-4
Comment by alexander raban (alraban) - Wednesday, 28 November 2018, 23:58 GMT
That appears to resolve my issues on a quick test: scantailor files work as expected, the missing features are back, everything appears to work correctly on a preliminary test.

Thank you very much for your time and attention to the issue!

Loading...