Community Packages

Please read this before reporting a bug:
http://wiki.archlinux.org/index.php/Reporting_Bug_Guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#60762 - [paraview] pegtl as makedepends ?

Attached to Project: Community Packages
Opened by Michel (xantares) - Saturday, 10 November 2018, 08:48 GMT
Last edited by Bruno Pagani (ArchangeGabriel) - Tuesday, 20 November 2018, 13:57 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Bruno Pagani (ArchangeGabriel)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

pegtl is a header-only library, I think it should be just listed a makedepends, not as depends
This task depends upon

Closed by  Bruno Pagani (ArchangeGabriel)
Tuesday, 20 November 2018, 13:57 GMT
Reason for closing:  Fixed
Additional comments about closing:  paraview 5.6.0-2
Comment by Bruno Pagani (ArchangeGabriel) - Wednesday, 14 November 2018, 16:06 GMT
I think ParaView needs the headers to be available (at least it embeds them from their ThirdParty vendored sources if you don’t add pegtl as a system dependency).
Comment by Michel (xantares) - Wednesday, 14 November 2018, 18:59 GMT
Yes, and it needs these only at build time not run time, so pegtl should be moved to makedepends.
Comment by Bruno Pagani (ArchangeGabriel) - Thursday, 15 November 2018, 09:36 GMT
By embed, I meant in the actual package/during `ninja install`. But that’s only from memory.

Anyway, I can remove the dep and we will see if anything happens.
Comment by Michel (xantares) - Thursday, 15 November 2018, 19:30 GMT
DONT remove it, just list it as makedepends.
Comment by Eli Schwartz (eschwartz) - Friday, 16 November 2018, 16:00 GMT
I'm sure the ninja install does install the headers, but this is cmake, so it would always install the headers as long as the pegtl CMakeLists.txt in the thirdparty directory says to.

This is because add_subdirectory reads the CMakeLists.txt with full, global context and inherits all install() calls. cmake fundamentally does not have sane handling for vendoring dependencies, so it's a good thing we remove them anyway...

EDIT: to be clear, I'm responding to Bruno, with an explanation for why looking at ninja install doesn't say anything about whether it is needed at runtime.
Comment by Michel (xantares) - Friday, 16 November 2018, 16:38 GMT
I'm not discussing whether paraview installs the pegtl headers.

I'm just saying that the pegtl package that is listed as dependency in the PKGBUILD should be listed as makedepends as it's only needed when building the package, not when running paraview.

Loading...