FS#60762 - [paraview] pegtl as makedepends ?
Attached to Project:
Community Packages
Opened by Michel (xantares) - Saturday, 10 November 2018, 08:48 GMT
Last edited by Bruno Pagani (ArchangeGabriel) - Tuesday, 20 November 2018, 13:57 GMT
Opened by Michel (xantares) - Saturday, 10 November 2018, 08:48 GMT
Last edited by Bruno Pagani (ArchangeGabriel) - Tuesday, 20 November 2018, 13:57 GMT
|
Details
pegtl is a header-only library, I think it should be just
listed a makedepends, not as depends
|
This task depends upon
Closed by Bruno Pagani (ArchangeGabriel)
Tuesday, 20 November 2018, 13:57 GMT
Reason for closing: Fixed
Additional comments about closing: paraview 5.6.0-2
Tuesday, 20 November 2018, 13:57 GMT
Reason for closing: Fixed
Additional comments about closing: paraview 5.6.0-2
Anyway, I can remove the dep and we will see if anything happens.
This is because add_subdirectory reads the CMakeLists.txt with full, global context and inherits all install() calls. cmake fundamentally does not have sane handling for vendoring dependencies, so it's a good thing we remove them anyway...
EDIT: to be clear, I'm responding to Bruno, with an explanation for why looking at ninja install doesn't say anything about whether it is needed at runtime.
I'm just saying that the pegtl package that is listed as dependency in the PKGBUILD should be listed as makedepends as it's only needed when building the package, not when running paraview.