FS#60460 - [packeth] Package misses packETHcli binary

Attached to Project: Community Packages
Opened by Kay Bouché (kay94) - Wednesday, 17 October 2018, 15:36 GMT
Last edited by Jelle van der Waa (jelly) - Sunday, 03 September 2023, 09:12 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture x86_64
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
packEth 1.9-1

The packETHcli binary is not build. It resides in another subdirectory 'cli' and has it's own Makefile. The 'make install' target of it seems to a bit broken (that's the reason for the 'cp' below).
There is also another packETHcli in another subdirectory 'cli_new'. But the build fails with a warning ('-Werror'), so maybe it's better to not use that.

Modifiying the PKGBUILD like following, the packETHcli is correctly built and installed.

diff --git a/tmp/packeth/repos/community-x86_64/PKGBUILD b/PKGBUILD
index 2de6454..b206466 100644
--- a/tmp/packeth/repos/community-x86_64/PKGBUILD
+++ b/PKGBUILD
@@ -17,9 +17,14 @@ build() {

./configure --prefix=/usr
make
+
+ cd "$srcdir"/packETH-$pkgver/cli
+ make
}

package() {
cd "$srcdir"/packETH-$pkgver
make install DESTDIR="$pkgdir/"
+
+ cp "$srcdir"/packETH-$pkgver/cli/packETHcli "$pkgdir"/usr/bin/
}

Would be great, if someone could incorporate this. I have also attached the diff.

Regards
   diff (0.4 KiB)
This task depends upon

Closed by  Jelle van der Waa (jelly)
Sunday, 03 September 2023, 09:12 GMT
Reason for closing:  Fixed
Additional comments about closing:  2.1-3
Comment by loqs (loqs) - Saturday, 12 September 2020, 18:25 GMT
Updated diff, the cli's Makefile uses custom CFLAGS including -Werror causing Wstringop-truncation warnings to become errors.
Custom empty LDFLAGS break RELRO and allows overlinking. The cli's Makefile also fails on make install requiring the binary to be manually installed.
   PKGBUILD.diff (0.5 KiB)
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.

Loading...