Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#60452 - [mksh] source checksum error

Attached to Project: Community Packages
Opened by Erich Eckner (deepthought) - Wednesday, 17 October 2018, 11:28 GMT
Last edited by Alad Wenter (Alad) - Sunday, 06 January 2019, 19:11 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Alad Wenter (Alad)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

==> Making package: mksh 56.c-4 (Mi 17 Okt 2018 13:27:36 CEST)
==> Retrieving sources...
-> Found mksh-R56c.tgz
-> Found TaC-mksh.txt
==> Validating source files with md5sums...
mksh-R56c.tgz ... Passed
TaC-mksh.txt ... FAILED
==> ERROR: One or more files did not pass the validity check!
Additional info:
* package version(s)
mksh 56.c-4 (git revision 71d40007affd3b613a61a2b96193e2b7e7bddf85)

Steps to reproduce:
> git checkout 71d40007affd3b613a61a2b96193e2b7e7bddf85
> cd mksh/repos/community-x86_64
> makepkg --verifysource
This task depends upon

Closed by  Alad Wenter (Alad)
Sunday, 06 January 2019, 19:11 GMT
Reason for closing:  Fixed
Additional comments about closing:  https://git.archlinux.org/svntogit/commu nity.git/commit/trunk?h=packages/mksh&am p;id=84b441ba93a9b79bfd9e4777ca1d95839c6 02c29
Comment by Alad Wenter (Alad) - Wednesday, 17 October 2018, 17:37 GMT
Since this file is continuously modified by upstream, and not part of the release tarball, we have the following options:

1. Bundle the terms and conditions as part of the package
This has the downside that the copy has to be kept up-to-date seperately.

2. Extract the MirOS license from the source file(s)
The source tarball contains certain files that do not apply under the MirOS license ("Appendix A").

I would suggest 2, combined with removing files that fall under a different license. These are

* mksh.ico ("Appendix D", an application icon) and
* strlcpy.c ("Appendix C", useless file to us).
Comment by Eli Schwartz (eschwartz) - Wednesday, 17 October 2018, 17:49 GMT
These both appear to be random files which are totally inert but happen to be in the tarball anyway. The former is not used when libc is better, and the latter is not used all.

We don't need license terms for that, we don't distribute it.
Comment by Alad Wenter (Alad) - Wednesday, 17 October 2018, 17:50 GMT
The fix should be simple then, just extract the license from main.c.

Loading...