FS#60318 - [midori] Will not build from PKGBUILD. GTK issue?

Attached to Project: Community Packages
Opened by Keith (keithg) - Friday, 05 October 2018, 16:17 GMT
Last edited by Alexander F. Rødseth (xyproto) - Wednesday, 17 October 2018, 08:32 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Alexander F. Rødseth (xyproto)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
1) the pkgfile will not actually download the archive
2) had to use wget to download from the midori website
3) make fails with some missing GTK files.


Additional info:
* package version(s)
5.11
* config and/or log files etc.
Makepkg problem:

$ makepkg
==> Making package: midori 0.5.11-8 (Fri 05 Oct 2018 11:13:36 AM CDT)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
-> Downloading midori_0.5.11_all_.tar.bz2...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 194 100 194 0 0 489 0 --:--:-- --:--:-- --:--:-- 489
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 67150 0 67150 0 0 48907 0 --:--:-- 0:00:01 --:--:-- 48907
==> Validating source files with sha256sums...
midori_0.5.11_all_.tar.bz2 ... Skipped
==> Extracting sources...
==> Starting prepare()...
/home/kgrider/midori/PKGBUILD: line 28: cd: midori-0.5.11: No such file or direc tory
==> ERROR: A failure occurred in prepare().
Aborting...

The download the file manually:
$ wget https://www.midori-browser.org/wp-content/uploads/2018/08/midori_0.5.11_all_.tar.bz2

Then try again:
$ makepkg
==> Making package: midori 0.5.11-8 (Fri 05 Oct 2018 11:15:28 AM CDT)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
-> Found midori_0.5.11_all_.tar.bz2
==> Validating source files with sha256sums...
midori_0.5.11_all_.tar.bz2 ... Skipped
==> Extracting sources...
-> Extracting midori_0.5.11_all_.tar.bz2 with bsdtar
==> Starting prepare()...
==> Starting build()...
-- The C compiler identification is GNU 8.2.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- valac 0.42.2 found
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.5.3")
-- Checking for modules 'libxml-2.0>=2.6;sqlite3>=3.6.19;gmodule-2.0;gio-2.0>=2.32.3;libsoup-gnome-2.4>=2.37.1'
-- Found libxml-2.0, version 2.9.8
-- Found sqlite3, version 3.25.1
-- Found gmodule-2.0, version 2.58.0
-- Found gio-2.0, version 2.58.0
-- Found libsoup-gnome-2.4, version 2.64.1
-- Checking for module 'zeitgeist-2.0>=0.3.14'
-- Found zeitgeist-2.0, version 1.0
-- Checking for module 'gcr-3>=2.32'
-- Found gcr-3, version 3.28.0
-- Checking for modules 'gtk+-3.0>=3.10.0;webkit2gtk-4.0>=2.3.91'
-- Found gtk+-3.0, version 3.24.1
-- Found webkit2gtk-4.0, version 2.22.2
-- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1")
-- gettext found: af am ar ast be bg bn bs ca ckb cs cy da de el en_AU en_CA en_GB eo es et eu fa fi fr gd gl he hi hr hu ia id it ja ka kk km ko ku ky lb lt lv ml ms nap nb nl nn no pa pl pt pt_BR ro ru sk sl sq sr sr@latin sv ta te th tr ug uk ur uz vi zh_CN zh_HK zh_TW
-- Configuring done
-- Generating done
-- Build files have been written to: /home/kgrider/midori/src/build
[77/256] Generating /home/kgrider/midori/src/midori-0.5.11...5.11/midori/midori-window.c;midori-core.vapi;midori-core.h
FAILED: midori/midori_valac.stamp
cd /home/kgrider/midori/src/build/midori && /usr/bin/valac -C --header=midori-core.h --library=midori-core --vapi=midori-core.vapi -b /home/kgrider/midori/src/midori-0.5.11/midori -d /home/kgrider/midori/src/build/midori --pkg=posix --pkg=linux --pkg=libxml-2.0 --pkg=sqlite3 --pkg=gmodule-2.0 --pkg=gio-2.0 --pkg=libsoup-2.4 --pkg=zeitgeist-2.0 --pkg=gtk+-3.0 --enable-deprecated --debug -D HAVE_EXECINFO_H -D HAVE_LIBSOUP_2_40_0 -D HAVE_LIBSOUP_2_48_0 -D HAVE_GTK3 -D HAVE_WEBKIT2 -D HAVE_WEBKIT2_3_91 /home/kgrider/midori/src/midori-0.5.11/midori/../katze/katze-separatoraction.vala /home/kgrider/midori/src/midori-0.5.11/midori/../katze/midori-hsts.vala /home/kgrider/midori/src/midori-0.5.11/midori/../katze/midori-paths.vala /home/kgrider/midori/src/midori-0.5.11/midori/../katze/midori-uri.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-bookmarksdatabase.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-completion.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-contextaction.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-database.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-dialog.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-download.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-extensions-column.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-historycompletion.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-historydatabase.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-notebook.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-panedaction.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-searchcompletion.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-settings.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-speeddial.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-tab.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-viewable.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-viewcompletion.vala /home/kgrider/midori/src/midori-0.5.11/midori/midori-window.vala /home/kgrider/midori/src/midori-0.5.11/midori/webkit2gtk-4.0.vapi /home/kgrider/midori/src/midori-0.5.11/katze/katze.vapi && touch /home/kgrider/midori/src/build/midori/midori_valac.stamp
zeitgeist-2.0.vapi:112.3-112.42: warning: DBus methods are recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
public abstract async void notify_delete ([DBus (signature = "(xx)")] GLib.Variant time_range, uint32[] event_ids) throws GLib.IOError;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
zeitgeist-2.0.vapi:77.3-77.34: warning: DBus methods are recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
public abstract string get_state () throws GLib.IOError;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
zeitgeist-2.0.vapi:84.3-84.30: warning: DBus methods are recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
public abstract uint32 state () throws GLib.IOError;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/home/kgrider/midori/src/midori-0.5.11/midori/../katze/midori-paths.vala:488.44-488.57: error: The name `STOCK_FILE' does not exist in the context of `Gtk'
return widget.render_icon (Gtk.STOCK_FILE, Gtk.IconSize.MENU, null);
^^^^^^^^^^^^^^
/home/kgrider/midori/src/midori-0.5.11/midori/midori-notebook.vala:396.82-396.96: error: The name `STOCK_CLOSE' does not exist in the context of `Gtk'
var action_close = new Midori.ContextAction ("TabClose", null, null, Gtk.STOCK_CLOSE);
^^^^^^^^^^^^^^^
Compilation failed: 2 error(s), 3 warning(s)
[78/256] cd /home/kgrider/midori/src/build/data && /usr/bi...idori-0.5.11/data/midori.appdata.xml.in midori.appdata.xml
Merging translations into midori.appdata.xml.
CREATED midori.appdata.xml
[79/256] cd /home/kgrider/midori/src/build/data && /usr/bi...ri/src/midori-0.5.11/data/midori.desktop.in midori.desktop
Merging translations into midori.desktop.
[80/256] cd /home/kgrider/midori/src/build/data && /usr/bi...5.11/data/midori-private.desktop.in midori-private.desktop
Merging translations into midori-private.desktop.
ninja: build stopped: subcommand failed.
==> ERROR: A failure occurred in build().
Aborting...


Steps to reproduce:
Download PKGFILE and makepkg
This task depends upon

Closed by  Alexander F. Rødseth (xyproto)
Wednesday, 17 October 2018, 08:32 GMT
Reason for closing:  Upstream
Additional comments about closing:  New version of Gtk breaks the current package. Waiting for new version from Midori upstream.
Comment by Alexander F. Rødseth (xyproto) - Monday, 08 October 2018, 07:47 GMT
Hi, thanks for reporting. I can reproduce the error.
Comment by Alexander F. Rødseth (xyproto) - Monday, 08 October 2018, 12:28 GMT
When patching the PKGBUILD so that Midori builds again, it crashes at startup.

Here's the PKGBUILD with heavy patching: http://ix.io/1oFJ

This is most likely because there is no release of Midori yet that supports Gtk 3.10 or later.

However, midori-browser/core on GitHub supports Gtk 3.12, so that is promising: https://github.com/midori-browser/core

Hopefully, Midori will make a new release soon.
Comment by Keith (keithg) - Monday, 08 October 2018, 21:12 GMT
Alexander,

Thanks for the info. I tried to build the midori-core, but the instructions are not complete and I do not understand what is missing.

Use CMake to build Midori:

mkdir _build
cd _build
cmake -DCMAKE_INSTALL_PREFIX=/usr ..
make
sudo make install

My guess is the cmake -DCMAKE line is longer than that because when I type that, nothing happens b/c there in nothing in _build.
Comment by Alexander F. Rødseth (xyproto) - Tuesday, 09 October 2018, 07:31 GMT
cmake is supposed to populate the the directory with files. If there is no files in _build after running cmake, there should be an error message telling what went wrong.

However, I don't think midori-browser/core is ready yet.
Comment by Alexander F. Rødseth (xyproto) - Tuesday, 09 October 2018, 13:10 GMT
Here is the issue tracker, if there are problems with the build process: https://github.com/midori-browser/core/issues
Comment by Alexander F. Rødseth (xyproto) - Wednesday, 17 October 2018, 08:32 GMT
Will close this one and wait for upstream to make a new release.

Loading...