FS#60311 - [aws-cli] Incompatible with python-rsa 4.x

Attached to Project: Community Packages
Opened by Musikolo (Musikolo) - Friday, 05 October 2018, 01:46 GMT
Last edited by Jonathan Steel (jsteel) - Friday, 10 July 2020, 21:10 GMT
Task Type General Gripe
Category Packages
Status Closed
Assigned To Jonathan Steel (jsteel)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

While building the `stsauth` package I maintain in AUR, I noticed that I had issues with `python-rsa` package. Looking into the issue, I found that `python-rsa` has recently been upgraded to version 4 which, unfortunately, breaks `aws-cli`, since such a version isn't supported yet:
- https://git.archlinux.org/svntogit/community.git/log/trunk?h=packages/python-rsa
- https://github.com/aws/aws-cli/blob/develop/requirements.txt#L12

So, the only ways I thought of to solve this issue are:
a) Create an upstream PR to request adding support for python-rsa 4.x
b) Create a new python-rsa3 package for backwards compatibility and use it as a replacement of `python-rsa` dependency. I temporary created such a package at https://aur.archlinux.org/packages/python-rsa3/

Thoughts?
This task depends upon

Closed by  Jonathan Steel (jsteel)
Friday, 10 July 2020, 21:10 GMT
Reason for closing:  Fixed
Additional comments about closing:  https://github.com/aws/aws-cli/pull/5355
Comment by Jonathan Steel (jsteel) - Monday, 08 October 2018, 10:20 GMT
Can you explain how to reproduce the issue you are seeing with packages in the repos? Or is the issue just when building an AUR package? I have python-rsa 4 and aws-cli isn't broken.
Comment by Musikolo (Musikolo) - Monday, 08 October 2018, 14:05 GMT
stsauth requires aws-cli. However, while stsauth strictly sticks to the aws-cli dependency requirements, aws-cli itself is not so strict. This causes stsauth to fail at compilation time. I originally reported this to stsauth developers. They responded stating that the problem is that aws-cli is using a version of python-rsa that is not officially supported which is true. You can learn more at https://github.com/cshamrick/stsauth/issues/12
Comment by Jonathan Steel (jsteel) - Monday, 08 October 2018, 16:25 GMT
Really I'd like some evidence that there's an issue that affects packages in the repositories; that is what this bug tracker is for. Otherwise I'd suggest reporting this upstream. It doesn't make sense to me to provide an old version of python-rsa officially to help with an AUR package.
Comment by Doug Newgard (Scimmia) - Monday, 08 October 2018, 16:31 GMT
The package in the repository does have a requires.txt with version constraints that python-rsa does not meet. If it's used with setuptools at all, it will fail.
Comment by Jonathan Steel (jsteel) - Monday, 08 October 2018, 17:16 GMT
I just built stsauth without issue. Can you provide an error and the steps you take to get there?
Comment by Musikolo (Musikolo) - Monday, 08 October 2018, 20:27 GMT
I'm traveling now and I won't be able to provide evidence until I get access you my home PC again. This will take a bit more than 2 weeks to me. If you want to try building stsauth-0.2.5 yourself, you'll see what I'm talking about. You can find the build script at aur at https://aur.archlinux.org/packages/stsauth/ . Just change version to 0.2.5 and you should see what I'm talking about.

Thank you!
Comment by Jonathan Steel (jsteel) - Tuesday, 09 October 2018, 08:13 GMT
Bumped to 0.2.5 and that builds too. However it seems we are now debugging an AUR package. I'll ask upstream to bump their requirements for python-rsa and I guess we are done here?
Comment by Musikolo (Musikolo) - Tuesday, 09 October 2018, 08:25 GMT
I'm surprised it worked for you. Regarding the request you want to do upstream, yes, that should solve the problem completely.

Thanks for your support and sorry for the inconvenience.
Comment by Jonathan Steel (jsteel) - Tuesday, 09 October 2018, 09:11 GMT
I haven't tested the package, but I got "==> Finished making: stsauth 0.2.5-1" from makepkg. I had to add the --user flag to the pip command in the PKGBUILD as it complained about permissions and suggested to do that.
Comment by Jonathan Steel (jsteel) - Monday, 22 October 2018, 09:58 GMT
Here's the upstream request for reference: https://github.com/aws/aws-cli/issues/3660. Would you rather I left this open until this is fixed or shall I close this one down and you can follow the upstream report? If I don't hear back in a few weeks I'll close this thanks.
Comment by Musikolo (Musikolo) - Thursday, 25 October 2018, 03:15 GMT
If you don't mind, I would rather leave it open until the issue is fully solved. I know it should be fixed upstream, but I think this way we get better traceability.

Thank you so much your help! ;-)

Loading...