FS#59788 - [r8168-lts] ship /usr/lib/modprobe.d/r8168-lts.conf similar to r8168.conf of r8168 package

Attached to Project: Community Packages
Opened by AMM (amish) - Friday, 24 August 2018, 10:05 GMT
Last edited by Massimiliano Torromeo (mtorromeo) - Tuesday, 02 October 2018, 08:21 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Massimiliano Torromeo (mtorromeo)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
Package r8168 ships with file /usr/lib/modprobe.d/r8168.conf which blacklists module r8169

This way if package is removed (blacklisting is also removed i.e. r8169 is accepted again)

But on the other hand, package r8168-lts uses install file to "echo / inform" user to manually blacklist the module by adding it to /etc/modprobe.d/r8169_blacklist.conf

This means that when user removes the package (in future) - blacklisting will continue to remain till the user figures it out on his own.

If we implement /usr/lib/modprobe.d/r8168-lts.conf (same content as r8168.conf) then:
1) We avoid .install file
2) Module blacklisting / unlisting happens automatically.

Also in my opinion PKGBUILD of r8168 and r8168-lts should be almost same except differences related to LTS.

Right now they differ a bit (although final list of files is more or les same)


Also, not creating another bug for this minor issue but, description of r8168-lts mentions r8169 but it should be r8168


Additional info:
* package version(s)
r8168-lts version 8.046.00-2
This task depends upon

Closed by  Massimiliano Torromeo (mtorromeo)
Tuesday, 02 October 2018, 08:21 GMT
Reason for closing:  Implemented
Additional comments about closing:  r8168-lts-8.046.00-6

Loading...