Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
FS#59506 - [vim] Fix potential problems in archlinux.vim
Attached to Project:
Arch Linux
Opened by Lukas (superlukas) - Wednesday, 01 August 2018, 14:29 GMT
Last edited by Levente Polyak (anthraxx) - Monday, 13 August 2018, 15:06 GMT
Opened by Lukas (superlukas) - Wednesday, 01 August 2018, 14:29 GMT
Last edited by Levente Polyak (anthraxx) - Monday, 13 August 2018, 15:06 GMT
|
DetailsThere are 2 potential problems in archlinux.vim.
1. nocompatible is set unconditionally. If someone sets nocompatible in /etc/vimrc and does a bunch of configuration below that and then sources archlinux.vim at the bottom, nocompatible is set a second time, which may break/undo some of the configuration done before. 2. suffixes is overwritten rather than added to (suffixes=foo instead of suffixes+=foo). If the vim maintainers decide to add a bunch of new suffixes to the list Arch users won't see them. I've fixed both of them in good.patch and also cleaned the file up a bit. (I've also removed 'set history=50' because 50 the default value.) The resulting configuration should be identical. I've also included better.patch which removes a lot of stuff from archlinux.vim that I don't think makes much sense to have in there. The suffix option is way too personal for archlinux.vim (or /etc/vimrc even), XTerm mappings probably are best kept in the ~/.vimrc of a XTerm user and the CVE-workaround should probably be in ~/.vimrc too because no other distro includes it globally so if you log in to a server from your Arch desktop you won't be protected. I've also added 2 options from defaults.vim and sensible.vim, making archlinux.vim basically a tiny subset of both of them. Feel free to pick the patch you like best. Thanks. |
This task depends upon
Closed by Levente Polyak (anthraxx)
Monday, 13 August 2018, 15:06 GMT
Reason for closing: Implemented
Additional comments about closing: 8.1.0279-1
Monday, 13 August 2018, 15:06 GMT
Reason for closing: Implemented
Additional comments about closing: 8.1.0279-1
good.patch
- checking nocompatible before setting makess totally sense gonna pull that in
- suffixes modification sounds reasonable as well, gonna pull in
- history default value sounds reasonable as well