FS#59449 - [samba] smb.service should depend on network-online.target

Attached to Project: Arch Linux
Opened by Oleksandr Natalenko (post-factum) - Wednesday, 25 July 2018, 19:32 GMT
Last edited by Tobias Powalowski (tpowa) - Friday, 07 September 2018, 16:42 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Tobias Powalowski (tpowa)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

If smb.service is enabled, but nmb.service is disabled, and if smb.conf contains explicit binding to specific network interfaces:

=== /etc/samba/smb.conf
…
interfaces = lo wlp1s0 enp3s0.128
bind interfaces only = yes
…
===

then, during the boot, smbd is not bound to those interfaces (except loopback).

If the following droplet is used:

=== /etc/systemd/system/smb.service.d/10-network-online.conf
[Unit]
After=network.target network-online.target nmb.service winbind.service
Wants=network-online.target
===

smb.service waits for all the interfaces to become up, and thus starts just fine.

So, the suggestion is to modify smb.service to depend on network-online.target just like nmb.service does.
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Friday, 07 September 2018, 16:42 GMT
Reason for closing:  Fixed
Additional comments about closing:  4.8.5-1
Comment by Eli Schwartz (eschwartz) - Wednesday, 25 July 2018, 22:52 GMT
  • Field changed: Category (Packages: Extra → Upstream Bugs)
  • Field changed: Architecture (x86_64 → All)
Since samba 4.8.0-1 all systemd units come from upstream. Please discuss with upstream whether this change makes sense.
Comment by Oleksandr Natalenko (post-factum) - Wednesday, 01 August 2018, 19:53 GMT
  • Field changed: Percent Complete (100% → 0%)
I've submitted an upstream patch (https://lists.samba.org/archive/samba-technical/2018-July/129373.html). but I'd appreciate having it backported into Arch now since I have a real use-case for it. Thanks.
Comment by Oleksandr Natalenko (post-factum) - Friday, 03 August 2018, 12:39 GMT
Upstream submission: https://lists.samba.org/archive/samba-technical/2018-August/129509.html
Upstream Bugzilla: https://bugzilla.samba.org/show_bug.cgi?id=13559
Comment by Oleksandr Natalenko (post-factum) - Friday, 03 August 2018, 12:45 GMT
Upstream patch is reviewed, testing is undergoing: https://git.samba.org/?p=asn/samba-autobuild/.git;a=commit;h=0852729ebe8bfe2038f0b61274c05cd19bb9dbb8
Comment by Oleksandr Natalenko (post-factum) - Friday, 03 August 2018, 18:33 GMT
Committed into the upstream: https://git.samba.org/?p=samba.git;a=commit;h=a3d248f284eb2e5f4fe886310e481b28c9f1c392

Please cherry-pick.

Loading...