FS#59395 - [firefox-developer-edition] Typo for C++ compiler flag in PKGBUILD?

Attached to Project: Community Packages
Opened by Leopold Bloom (leopoldbloom) - Thursday, 19 July 2018, 20:13 GMT
Last edited by Andrew Crerar (andrewSC) - Friday, 20 July 2018, 19:24 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Andrew Crerar (andrewSC)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


I took a look at the PKGBUILD just now and noticed that clang++ was being set for the "CCX" flag, which AFAIK doesn't exist as a make flag, and strikes me as a typo of "CXX". I'm assuming this is a silent error as it sets a meaningless "CCX" flag to clang++ and continues compilation with g++.
This task depends upon

Closed by  Andrew Crerar (andrewSC)
Friday, 20 July 2018, 19:24 GMT
Reason for closing:  Fixed
Additional comments about closing:  Found the issue with the missing symbols in reports and it's not related to the PKGBUILD, but rather a step I've been missing after building. Updated PKGBUILD to remove "CCX" flag with 62.0b10. Closing this.
Comment by Andrew Crerar (andrewSC) - Thursday, 19 July 2018, 22:32 GMT
There's actually a CCX flag! ..just kidding.

It was a typo on my part and I'm actually in the process of reverting the change. In backing it out I found out that the crash reports are missing symbols so I'm working through that and hope to have everything resolved by the next upstream tag (or sooner). I'm going to leave this open until I resolve the missing symbols issue though.