FS#59216 - [thunar] Custom actions without an icon could cause the file manager to crash

Attached to Project: Arch Linux
Opened by Philip Müller (philm) - Monday, 02 July 2018, 17:47 GMT
Last edited by Evangelos Foutras (foutrelis) - Tuesday, 03 July 2018, 11:30 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Evangelos Foutras (foutrelis)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Thunar crashes if the context menu of a file that has a custom action without icon, if this action is the first (of that type of file) thunar crashes when selecting the file. If a custom action for directories hasn't an icon thunar crashes at startup.

Additional info:
* thunar 1.8.1-1

Steps to reproduce:

Add a custom action without icons, use the pattern that you like.
Click on a file that matches the pattern or open the context menu.

Reported upstream: https://bugzilla.xfce.org/show_bug.cgi?id=14464
Fixed in master: https://git.xfce.org/xfce/thunar/commit?id=510c8779584edf2f113c379cb024370cf844412b
This task depends upon

Closed by  Evangelos Foutras (foutrelis)
Tuesday, 03 July 2018, 11:30 GMT
Reason for closing:  Fixed
Additional comments about closing:  thunar 1.8.1.11.gf5147445-1
Comment by Philip Müller (philm) - Monday, 02 July 2018, 18:03 GMT
Suggested fix with others:

source=(https://archive.xfce.org/src/xfce/$pkgname/${pkgver%.*}/Thunar-$pkgver.tar.bz2
bug-14464.patch::https://git.xfce.org/xfce/thunar/patch/?id=510c8779584edf2f113c379cb024370cf844412b
bug-14461.patch::https://git.xfce.org/xfce/thunar/patch/?id=4fa24d42f83180fd5012527eb4ed77b04e8d88a6
bug-14459.patch::https://git.xfce.org/xfce/thunar/patch/?id=e37c83abc600e9fec40508283e07cd92a5ece8b6
fix-ISO-C90-warning.patch::https://git.xfce.org/xfce/thunar/patch/?id=897f06efea7b177b471caa4698895e35ca06b4a1
bug-14461-p2.patch::https://git.xfce.org/xfce/thunar/patch/?id=660d9ceb8509ef82fe3a4a0287014010286bf12c
bug-14433.patch::https://git.xfce.org/xfce/thunar/patch/?id=6e2b1d762ba177fba19e0bb4d466f5a1ed524df4)
sha256sums=('96fabaa68db32f513e9bcb34fa2a26c1462127727fad0bc25a8a5ba9aab4c12c'
'9cf14c76cde6412906b7e05925e89c46fbecfe04d69f531b77a17c32dcfa867f'
'0ba250c06fa3ddf41b6fc31a2ceb90d2b9ac7ff9bf724bde623cf1ad0a9a0c0a'
'852ab5e88e4e2e3e6d488d5fd749d361b990443092ea46577f394166a2afb749'
'4b0a786ebe7dd28210244e867989f623a2e0b13b574db43f2f3eff71d8be6378'
'bda394336ea387675ca243688eb85a54d4564fc977ec3092bf27a4d3b8d9c316'
'5f3c472be568fbf9e96f8ed69c049e0b7f8ac5e85b5a546173fffbbf302e1e29')

prepare() {
cd "$srcdir/Thunar-$pkgver"
patch -p1 -i ../bug-14464.patch
patch -p1 -i ../bug-14461.patch
patch -p1 -i ../bug-14459.patch
patch -p1 -i ../fix-ISO-C90-warning.patch
patch -p1 -i ../bug-14461-p2.patch
patch -p1 -i ../bug-14433.patch
}

Loading...