Arch Linux

Description:

community/xpra-2.3.1-5, as currently packaged, has a reference to $pkgdir for one of its config files, etc/xpra/conf.d/55_server_x11.conf

Additional info:

When building locally from downloaded PKGBUILD, makepkg reports this warning:
"==> WARNING: Package contains reference to $pkgdir
etc/xpra/conf.d/55_server_x11.conf"

This is true for the current version, xpra-2.3.1-5, but I vaguely remember this or a similar problem(?) back when the package was xpra-winswitch in AUR, so possibly this is an ongoing issue...?

Steps to reproduce:

1.) Install xpra-2.3.1-5.
2.) `grep /build/xpra/pkg/xpra/etc/xpra/xorg.conf /etc/xpra/conf.d/55_server_x11.conf'
3.) References to the build host's $pkgdir, /build/xpra/pkg, are found
4.) These references should simply be /etc/xpra/xorg.conf

Here's a very short .patch file to fix this (NOTE: I HOPE this works, I haven't set up a build container to test this for accuracy):

--- PKGBUILD.orig 2018-06-22 06:06:55.753650513 -0400
+++ PKGBUILD 2018-06-22 06:48:15.637671742 -0400
@@ -53,6 +53,9 @@
package() {
cd "${srcdir}/$pkgname-$pkgver"
python2 setup.py install --root="${pkgdir}" --optimize=1 --skip-build --without-enc_x265
+
+ sed -i 's|/build/xpra/pkg/xpra/etc/xpra/xorg.conf|/etc/xpra/xorg.conf|' "${pkgdir}"/etc/xpra/conf.d/55_server_x11.conf
+
mv "${pkgdir}"/lib/* "${pkgdir}"/usr/lib/
rmdir "${pkgdir}/lib"
}

I do suspect this is an upstream bug because this step of the build:

"convert_templates(['conf.d']) dirname=etc/xpra/conf.d, target_dir=build/etc/xpra/conf.d
...
...
generating build/etc/xpra/conf.d/55_server_x11.conf from 55_server_x11.conf.in
..."

seems not to be doing what it should(?), but I'll leave that to the package maintainer (hoping that's appropriate).

As always, HTH.

Clemmitt Sigler