FS#59100 - [mdadm] Monitor config file typo

Attached to Project: Arch Linux
Opened by Len Huppe (lhuppe) - Thursday, 21 June 2018, 14:20 GMT
Last edited by Doug Newgard (Scimmia) - Sunday, 05 August 2018, 15:06 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When trying to start the mdmonitor service I got an error.

One look at the mdmonitor.service file revealed the issue.

Envinronment= MDADM_MONITOR_ARGS=--scan

Should read

Envinronment=MDADM_MONITOR_ARGS=--scan

After that edit I did the usual

$ sudo systemctl daemon-reload

$ sudo systemctl start mdmonitor.service

$ sudo systemctl status mdmonitor.service



Voila!
This task depends upon

Closed by  Doug Newgard (Scimmia)
Sunday, 05 August 2018, 15:06 GMT
Reason for closing:  No response
Comment by Doug Newgard (Scimmia) - Friday, 22 June 2018, 16:48 GMT
Complaining about a typo then making multiple typos in the lines you're talking about makes things pretty unclear. What, exactly, do you want changed? This file comes from upstream anyway, not from Arch, so if there's actually a problem, you'd want to talk to them.
Comment by Len Huppe (lhuppe) - Saturday, 23 June 2018, 12:26 GMT
My sincerest apologies if I was unclear. I will do better next time. I just want to help out if that is at all possible. I am a healthcare worker and not a programmer. However, I found a typo in the mdmonitor.service file that prevents the service from starting. It was unclear to me who I should report the bug to. You have now answered that question.

Meanwhile, anyone who wants to use the service can do so very easily. The mdmonitor.service file looks like this:


[qoute]
# This file is part of mdadm.
#
# mdadm is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.

[Unit]
Description=MD array monitor
DefaultDependencies=no

[Service]
Environment= MDADM_MONITOR_ARGS=--scan
EnvironmentFile=-/run/sysconfig/mdadm
ExecStartPre=-/usr/lib/systemd/scripts/mdadm_env.sh
ExecStart=/sbin/mdadm --monitor $MDADM_MONITOR_ARGS
[/quote]


The bug is the spaces in the "Environment= MDADM_MONITOR_ARGS=--scan" line.



Thanks!



P.S. If I may, what multiple typos are you referring to?
Comment by Eli Schwartz (eschwartz) - Tuesday, 17 July 2018, 18:15 GMT
  • Field changed: Summary (Mdadm Monitor config file typo → [mdadm] Monitor config file typo)
  • Field changed: Status (Unconfirmed → Assigned)
  • Field changed: Category (Other → Upstream Bugs)
  • Field changed: Architecture (x86_64 → All)
  • Task assigned to Tobias Powalowski (tpowa)
"Envinronment"?

The space after the "="?

...

This extra space comes from the very first revision of the file in the upstream git: https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/systemd/mdmonitor.service?id=61c094715836e76b66d7a69adcb6769127b5b77d

Please report an upstream bug to the mdadm project, and provide the link to the bug report here so we can track it.
Comment by Eli Schwartz (eschwartz) - Tuesday, 17 July 2018, 18:22 GMT
systemd.exec(5) should not care about the extra space anyway, even though it is arguably cleaner to not have it there.

$ systemctl show mdmonitor.service -q -p Environment
Environment=MDADM_MONITOR_ARGS=--scan

"When trying to start the mdmonitor service I got an error."

What error did you get, exactly, and why do you think the Environment= key is at fault?

Loading...