FS#59096 - [linux] Kernel 4.17.2 freeze when thinkpad_acpi loaded

Attached to Project: Arch Linux
Opened by Daniel Milde (dundee) - Thursday, 21 June 2018, 05:51 GMT
Last edited by Doug Newgard (Scimmia) - Friday, 20 July 2018, 18:33 GMT
Task Type Bug Report
Category Kernel
Status Closed
Assigned To Tobias Powalowski (tpowa)
Jan Alexander Steffens (heftig)
Architecture All
Severity Critical
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 5
Private No

Details

Description:
Boot crashes with stack trace when module thinkpad_acpi is loaded.

Thinkpad_acpi should be probably removed for now.

More info: https://bbs.archlinux.org/viewtopic.php?pid=1792927

Additional info:
* linux 4.17.2
* Thinkpad HW


Steps to reproduce:
boot with linux 4.17.2 on Thinkpad notebook.
This task depends upon

Closed by  Doug Newgard (Scimmia)
Friday, 20 July 2018, 18:33 GMT
Reason for closing:  Fixed
Additional comments about closing:  linux 4.17.6-1
Comment by Jouke Witteveen (jouke) - Saturday, 23 June 2018, 09:19 GMT
I was bitten by this too and believe to have fixed it with the attached patch (submitted: https://marc.info/?l=linux-acpi&m=152974494120349&w=2).
   battery.patch (1.9 KiB)
Comment by Jouke Witteveen (jouke) - Sunday, 24 June 2018, 14:00 GMT
For those who want to use the patch, here is a rough guide (see also https://wiki.archlinux.org/index.php/Compile_kernel_module):

$ asp export linux
$ cd linux
$ makepkg -o
$ cd src/linux-4.17
$ patch -p1 -i <path/to/>battery.patch
$ make modules_prepare
$ make M=drivers/acpi
$ xz drivers/acpi/battery.ko

# cp -f drivers/acpi/battery.ko.xz /usr/lib/modules/4.17.2-1-ARCH/kernel/drivers/acpi

Following these steps, you do not build the entire kernel. It will only take a few minutes.
Comment by Hong Shick Pak (hspak) - Wednesday, 27 June 2018, 05:20 GMT
FWIW, I don't have any issues with my Thinkpad Laptop (X1 Carbon 5th Gen, 20HR).

$ uname -a
Linux tx 4.17.2-1-ARCH #1 SMP PREEMPT Sat Jun 16 11:08:59 UTC 2018 x86_64 GNU/Linux

$ lsmod |grep thinkpad ~
thinkpad_acpi 106496 1
nvram 16384 1 thinkpad_acpi
rfkill 28672 7 thinkpad_acpi,cfg80211
snd 98304 23 snd_hda_codec_generic,snd_hda_codec_conexant,snd_hda_codec_hdmi,snd_hwdep,snd_hda_intel,snd_hda_codec,snd_timer,snd_compress,thinkpad_acpi,snd_soc_core,snd_pcm
led_class 16384 3 input_leds,iwlmvm,thinkpad_acpi
battery 24576 1 thinkpad_acpi
Comment by Jouke Witteveen (jouke) - Wednesday, 27 June 2018, 08:20 GMT
The issue manifests itself when the battery is not supported by the current thinkpad_acpi driver. Apparently, this is the case for the Thinkpad 13. That is the laptop the original reporter and I use.
Comment by PEAR (PEAR) - Tuesday, 03 July 2018, 12:20 GMT
Thinkpad 13 user here... same problem for me. Any information when the updated kernel will be available in the repositories?
Comment by Jouke Witteveen (jouke) - Thursday, 05 July 2018, 12:15 GMT
The patch is accepted upstream:
https://marc.info/?l=linux-acpi&m=153079039414291&w=2
Comment by loqs (loqs) - Thursday, 05 July 2018, 14:26 GMT
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=acpi&id=673b4271665a12fa839a12abb50e6f6e9953c081
Edit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=673b4271665a12fa839a12abb50e6f6e9953c081
Comment by loqs (loqs) - Tuesday, 10 July 2018, 14:05 GMT
Queued for 4.17.6 https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.17/acpi-battery-safe-unregistering-of-hooks.patch?id=c8ccd98e6e7e18e01a9152e62691809829f0a582
Comment by PEAR (PEAR) - Wednesday, 18 July 2018, 09:36 GMT
Just installed 4.17.6 yesterday - everything works fine now.

Loading...