FS#59084 - [plasma5-applets-redshift-control] broken behaviour

Attached to Project: Community Packages
Opened by grmat (grmat) - Wednesday, 20 June 2018, 09:11 GMT
Last edited by Bruno Pagani (ArchangeGabriel) - Friday, 22 June 2018, 13:30 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Bruno Pagani (ArchangeGabriel)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

redshift changed its default behaviour for one-shot changes, long story short: it now requires an additional parameter for the method used in the applet for mouse wheel scrolling or it will mess up the gamma up to a point where the user can't see anything on the screen. Since Arch is rolling-release, redshift has been updated to 1.12, leading to the broken behaviour.

upstream bug report: https://bugs.kde.org/show_bug.cgi?id=395641

While this package is still based on the outdated GitHub-version, you should at least offer the patch to fix the issue.

Additional info:
* package version(s):
redshift: 1.12-1
plasma5-applets-redshift-control: 1.0.18-1


Steps to reproduce:
Enable redshift applet on up-to-date Arch system, scroll mouse wheel up and down.

Possible solutions:
* in PKGBUILD/prepare(): sed -ie "s/redshift -O/redshift -PO/g" package/contents/ui/main.qml
* add a patch to the source repo, array, patch in prepare(), see attachment
This task depends upon

Closed by  Bruno Pagani (ArchangeGabriel)
Friday, 22 June 2018, 13:30 GMT
Reason for closing:  Fixed
Additional comments about closing:  1.0.18-2
Comment by Bruno Pagani (ArchangeGabriel) - Thursday, 21 June 2018, 17:36 GMT
Why are you saying “outdated GitHub-version”? There has been zero code changes since it moved to phabricator, and no release was issued from there AFAIK. And before that, only translations updates.

Anyway, rebuild will happen, but for now there is a mismatching checksum issue blocking it.
Comment by grmat (grmat) - Friday, 22 June 2018, 12:47 GMT
> Why are you saying “outdated GitHub-version”?

Yeah, that came off the wrong way, sorry. I just wanted to note that the project has moved.

Are you considering adding a patch to the package until upstream is updated?
Comment by Bruno Pagani (ArchangeGabriel) - Friday, 22 June 2018, 12:48 GMT
I’ve already added the patch, but the build won’t get out until https://github.com/kotelnik/plasma-applet-redshift-control/issues/56 is answered.
Comment by grmat (grmat) - Friday, 22 June 2018, 13:09 GMT
Thanks for the info.

I just downloaded the latest release and don't get a checksum mismatch. However, I see you've updated the upstream URL to phabricator in the PKGBUILD and you're using it ($url) to get the the url of the source package. So you should adjust either the source string or revert the upstream url again until a release is tagged from phabricator. If that oversight is really the current problem, it's my fault, sorry for the confusion.
Comment by Bruno Pagani (ArchangeGabriel) - Friday, 22 June 2018, 13:28 GMT
No, I’m the one who feel stupid…

Loading...