FS#59074 - [playonlinux] Icons are not being installed to the correct directory

Attached to Project: Community Packages
Opened by Raphael Costa (Raphael_Costa) - Tuesday, 19 June 2018, 20:20 GMT
Last edited by Toolybird (Toolybird) - Saturday, 15 April 2023, 02:26 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Laurent Carlier (lordheavy)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: This package is not installing icons to /usr/share/icons. In my installation I copied them manually from /usr/share/playonlinux/etc/playonlinux{16,22,32}.png to /usr/share/icons/hicolor/{16x16,22x22,32x32}/apps/pĺayonlinux.png (and ignored the other image sizes) in order for the icons to appear on KDE Launcher and KDE Panel but the problem should occur with any graphical environment.

The less optimal solution is to simply move these icons to the correct place, the optimal solution is not only moving them but also adding the missing icon sizes.


Additional info:
* package version(s): 4.2.12-1

Steps to reproduce:
* Install package
* run pacman -Ql playonlinux|grep icons
* Verify the icons are not in the correct directory
This task depends upon

Closed by  Toolybird (Toolybird)
Saturday, 15 April 2023, 02:26 GMT
Reason for closing:  None
Additional comments about closing:  Pkg was dropped to the AUR in May 2022.
Comment by Eli Schwartz (eschwartz) - Tuesday, 19 June 2018, 21:47 GMT
  • Field changed: Summary (Icons are not being installed to the correct directory → [playonlinux] Icons are not being installed to the correct directory)
  • Field changed: Status (Unconfirmed → Assigned)
  • Task assigned to Laurent Carlier (lordheavy)
I don't understand this package at all, why doesn't it use the upstream Makefile which puts the many files in the right places, and has the benefit of providing real locales, manpages, appdata, etc.
Comment by Laurent Carlier (lordheavy) - Thursday, 05 July 2018, 11:48 GMT
Icons are installed in the correct directory, see https://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

"Icons and themes are looked for in a set of directories. By default, apps should look in $HOME/.icons (for backwards compatibility), in $XDG_DATA_DIRS/icons and in /usr/share/pixmaps (in that order). Applications may further add their own icon directories to this list, and users may extend or change the list (in application/desktop specific ways).In each of these directories themes are stored as subdirectories. A theme can be spread across several base directories by having subdirectories of the same name. This way users can extend and override system themes."

Comment by Eli Schwartz (eschwartz) - Thursday, 05 July 2018, 15:08 GMT
Well, now they are in the pixmaps folder, yes. :)

I'm currently a bit confused why when you switched to the provided Makefile, you still use:
mv -v ${pkgdir}/usr/share/locale ${pkgdir}/usr/share/playonlinux/lang/locale

Is playonlinux explicitly looking there even though their Makefile tries to install to /usr/share/locale?

Loading...