FS#59043 - [etherwall] wrong ew-node git submodule in PKGBUILD

Attached to Project: Community Packages
Opened by Ales Katona (almindor) - Sunday, 17 June 2018, 15:48 GMT
Last edited by Felix Yan (felixonmars) - Monday, 10 September 2018, 09:44 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Felix Yan (felixonmars)
Architecture x86_64
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:
Package is build with old version of ew-node causing a bug not present if built from source.

Additional info:
* 2.2.3-1


Steps to reproduce:
Build package according to PKGCONFIG. Run Etherwall with thin mode enabled (default) and get an error on init.

ew-node is set to commit _ewnodecommit=9d9fbbe18a44a36456b90f51d14c241228b53c30 inside PKGBUILD.
The ew-node submodule has been updated on upstream to commit 08a4f7b8fda0caf3e9b3ac5fc436965772becca9 for this release.

Attached PKGBUILD with a fix.
   PKGBUILD (1.9 KiB)
This task depends upon

Closed by  Felix Yan (felixonmars)
Monday, 10 September 2018, 09:44 GMT
Reason for closing:  Fixed
Additional comments about closing:  2.2.4-1
Comment by lukpod (lukpod) - Sunday, 09 September 2018, 22:48 GMT
Upstream reports:

https://github.com/almindor/etherwall/issues/107
https://github.com/almindor/etherwall/issues/108

Meanwhile a new release has been made:

https://github.com/almindor/etherwall/releases
Comment by Ales Katona (almindor) - Monday, 10 September 2018, 06:35 GMT
I've added a version check between defines in ew-node/etherwall to prevent these kind of mismatches in the future. You need to ensure that etherwall is being built with the correct ew-node commit (latest should always work with latest).
Comment by Felix Yan (felixonmars) - Monday, 10 September 2018, 09:44 GMT
Sorry for the long delay, I somehow missed this report.

Loading...