FS#58999 - [hub] Install fish completion script

Attached to Project: Community Packages
Opened by Simon Legner (simon04) - Wednesday, 13 June 2018, 12:56 GMT
Last edited by Eli Schwartz (eschwartz) - Friday, 13 July 2018, 04:18 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Johannes Löthberg (demize)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Since v2.3.0 [1], a fish completion script is provided at [2]. Please add this script to the package under /usr/share/fish/completions/. Thank you!

[1] https://github.com/github/hub/releases/tag/v2.3.0
[2] https://github.com/github/hub/blob/master/etc/hub.fish_completion
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Friday, 13 July 2018, 04:18 GMT
Reason for closing:  Fixed
Additional comments about closing:  hub 2.4.0-2
Comment by pancho horrillo (pancho) - Wednesday, 13 June 2018, 20:02 GMT
Darn, I was going to open the issue, and got here too late! :-)

This the missing line, in case you find it helpful:

install -Dm644 etc/hub.fish_completion "$pkgdir"/usr/share/fish/vendor_completions.d/hub.fish


As you have seen, I've preferred the dir `vendor_completions.d` over `completions`, see ¹ to see why.


Thanks a bunch!

[1]: https://fishshell.com/docs/current/index.html#completion-path

Loading...