FS#58984 - [git] perl-term-readkey dependency is also needed for interactive.singlekey support

Attached to Project: Arch Linux
Opened by Quint Guvernator (qguv) - Tuesday, 12 June 2018, 16:52 GMT
Last edited by Christian Hesse (eworm) - Sunday, 07 October 2018, 07:07 GMT
Task Type General Gripe
Category Packages: Extra
Status Closed
Assigned To Christian Hesse (eworm)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

The reason listed for the git optional dependency perl-term-readkey is "git svn", but that dependency is also needed for the interactive.singlekey feature that can be enabled using git config. It's low-priority, but it would be nice to see interactive.singlekey added to the explanation for the optional dependency perl-term-readkey.

Additional info:
* affects package versions through 2.17.1-1
* only affects interactive.singlekey feature, which can be enabled using `git config interactive.singlekey true`

Steps to reproduce:

0. install git
1. ensure perl-term-readkey is not installed
2. clone a repository
3. `git config interactive.singlekey true`
4. make a change
5. `git add --patch`
6. see that Return is required when choosing whether to add a hunk
7. install perl-term-readkey
8. `git add --patch`
9. see that Return is no longer required
This task depends upon

Closed by  Christian Hesse (eworm)
Sunday, 07 October 2018, 07:07 GMT
Reason for closing:  Implemented
Additional comments about closing:  git-2.19.1-1
Comment by Quint Guvernator (qguv) - Tuesday, 21 August 2018, 13:33 GMT
Any status on this?

Loading...