FS#58809 - Comments in directives are no longer ignored

Attached to Project: Pacman
Opened by Peter Wu (Lekensteyn) - Thursday, 31 May 2018, 18:14 GMT
Last edited by Allan McRae (Allan) - Friday, 27 July 2018, 00:59 GMT
Task Type Bug Report
Category Documentation
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version 5.1.0
Due in Version 5.1.1
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:
Since upgrading from pacman 5.0.2-3 to pacman 5.1.0-2, all requests started failing. Invoking "pacman -Sy" for example would only perform requests to "/core/os/x86_64 " (note the odd space at the end).

It turns out that my custom mirror configuration with comments were parsed differently due to  FS#48702 :
Server = http://10.0.2.2:8080/$repo/os/$arch # comment here
It used to be parsed as "http://10.0.2.2:8080/$repo/os/$arch", but is now parsed as "http://10.0.2.2:8080/$repo/os/$arch # comment here". Due to how URLs work, everything appended after that is ignored.

This was not entirely obvious given that bash scripts and makepkg config accept comments like that just fine. If this is disallowed, consider updating pacman.conf(5).

https://xkcd.com/1172/
This task depends upon

Closed by  Allan McRae (Allan)
Friday, 27 July 2018, 00:59 GMT
Reason for closing:  Implemented
Additional comments about closing:  documentation added in 41cbea29
Comment by Eli Schwartz (eschwartz) - Thursday, 31 May 2018, 18:46 GMT
pacman.conf is most emphatically not bash.

Regarding our custom ini-style parser, there does not appear to be any documentation that says it is possible, which needs to be corrected.
Comment by Allan McRae (Allan) - Friday, 01 June 2018, 04:04 GMT
  • Field changed: Category (General → Documentation)
  • Field changed: Due in Version (Undecided → 5.1.1)
Reopening until documentation is fixed.

Loading...