FS#58744 - [apcupsd] Numerous issues in apcupsd. Please merge in fixes found in other Linux distributions.

Attached to Project: Community Packages
Opened by Lance (Raansu) - Sunday, 27 May 2018, 16:12 GMT
Last edited by Florian Pritz (bluewind) - Tuesday, 29 May 2018, 20:07 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Florian Pritz (bluewind)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description: There a number of issues with the apcupsd package in Arch Linux. I see many of these issues seemed fixed over at redhat/fedora, can those fixes be merged into the Arch Linux package?

Issues include:
* apcupsd not powering down the UPS when the system has halted. There needs to be a script added.
* apcupsd.service hangs and doesn't get properly stopped on shutdown

Related bug ticket
https://bugzilla.redhat.com/show_bug.cgi?id=1472062

The fixes are found in https://bodhi.fedoraproject.org/updates/FEDORA-2018-da8bd6a8c2 and related source https://kojipkgs.fedoraproject.org//packages/apcupsd/3.14.14/11.fc28/src/apcupsd-3.14.14-11.fc28.src.rpm

Additional info:
* package version(s)
apcupsd 3.14.14-2


Steps to reproduce: Installing apcupsd and enabling the service.
This task depends upon

Closed by  Florian Pritz (bluewind)
Tuesday, 29 May 2018, 20:07 GMT
Reason for closing:  Fixed
Comment by Florian Pritz (bluewind) - Tuesday, 29 May 2018, 18:19 GMT
Please test with apcupsd 3.14.14-3 which is in community-testing.
Comment by Lance (Raansu) - Tuesday, 29 May 2018, 19:45 GMT
It works here just fine, thank you for merging in the fixes. When I yanked my UPS power cable then waited sometime, my system successfully shutdown and also powered off the UPS. I was able to plugin my UPS and have my computer power itself back on again automatically.


I have one concern however, it doesn't effect me currently because I have no other scripts besides apcupsd_shutdown. But is it possible that "/usr/lib/systemd/system-shutdown/apcupsd_shutdown" could override other system-shutdown scripts?
Comment by Florian Pritz (bluewind) - Tuesday, 29 May 2018, 19:48 GMT
According to the documentation all scripts in that directory are run in parallel so sure, it can break something if the system looses power instantly, but there isn't much we can do about that. That said, I believe this part of the code is run at the very end so it should be fine.

Thanks for testing!
Comment by Lance (Raansu) - Tuesday, 29 May 2018, 20:07 GMT
I figured it shouldn't matter much since it seems to be at the vary end of the shutdown sequence but I wasn't entirely sure.

Thank you for all the help.

Loading...