FS#58661 - [dnscrypt-proxy] Service file misses dependence on socket

Attached to Project: Community Packages
Opened by Tommy Schmitt (spinka) - Saturday, 19 May 2018, 10:21 GMT
Last edited by David Runge (dvzrv) - Monday, 21 May 2018, 17:22 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To David Runge (dvzrv)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

Previously upstream service had dependence on socket:
https://github.com/jedisct1/dnscrypt-proxy/blob/85f05ff9e8c47e6e6613441644859c1c813f1fac/systemd/dnscrypt-proxy.service#L6
https://github.com/jedisct1/dnscrypt-proxy/blob/85f05ff9e8c47e6e6613441644859c1c813f1fac/systemd/dnscrypt-proxy.service#L49

Current downstream Archlinux service lacks of it. This is a problem because dnscrypt-proxy config in Archlinux doesn't include listening port: https://git.archlinux.org/svntogit/community.git/tree/trunk/configuration.diff?h=packages/dnscrypt-proxy#n9

That means service won't work when socket isn't enabled and started before. It can be fixed either by adding dependence on socket in service or adding listening port in config.

Steps to reproduce:
Enable and activate dnscrypt-proxy.service
systemctl enable --now dnscrypt-proxy.service
This task depends upon

Closed by  David Runge (dvzrv)
Monday, 21 May 2018, 17:22 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with 2.0.14-2
Comment by Tommy Schmitt (spinka) - Monday, 21 May 2018, 09:15 GMT
Users are already reporting issues related this: https://github.com/jedisct1/dnscrypt-proxy/issues/456 .

I don't think this should have severity 'low' as it's clearly miss-configured.
Comment by David Runge (dvzrv) - Monday, 21 May 2018, 17:21 GMT
@spinka: Thanks for bringing this to my attention.

As upstream rage-quitted systemd support, I had to add the service/socket. However, after decoupling their usage, I forgot to undo the changes in the configuration file (which were needed before).
This package requires a lot of customization on each release... :-/

Loading...