FS#58633 - [iputils] Remove deprecated sysfsutils dependency

Attached to Project: Arch Linux
Opened by Leonid Isaev (lisaev) - Thursday, 17 May 2018, 10:34 GMT
Last edited by Tobias Powalowski (tpowa) - Thursday, 12 July 2018, 04:53 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Tobias Powalowski (tpowa)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Sysfsutils has been dead for over 10 years now and most packages that depend on it have moved on to accessing /sys directly. Here is Debian TODO list on deprecating libsysfs:mpitt@debian.org"> https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=libsysfs-deprecation;users=mpitt@debian.org .

[core]/iputils is one such package: pls see the attached diff (PKGBUILD.patch) against current SVN trunk that removes sysfsutils dep and also gets rid of an unused variable for make(1).

Additionally, modern-day iputils (i) do not require perl-sgmls for manpages and use docbook-xsl instead (commit be0657da8842e90db446b10fbb9335d9033c54f2); and (ii) sign commits with a github key 4AEE18F83AFDEB23. Attached PKGBUILD.future takes care of these changes -- it was checked to produce a working package from commit 5f5a34c1b4d418ea68c27c00d3a0c173dd5560d6.

Thanks!
   PKGBUILD.patch (0.8 KiB)
   PKGBUILD.future (1.5 KiB)
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Thursday, 12 July 2018, 04:53 GMT
Reason for closing:  Fixed
Additional comments about closing:  2018.06.29-2
Comment by Eli Schwartz (eschwartz) - Thursday, 17 May 2018, 14:22 GMT
That PGP key is about as meaningless as you can get, it says nothing except that the commit was generated through github.com's web interface.

In order to update to a newer snapshot, we'd need to switch libidn => libidn2 as well:
https://github.com/iputils/iputils/commit/665fe4d30ff8b6649454ae25e4768b2f23605332

doc moving to xml:
https://github.com/iputils/iputils/commit/be0657da8842e90db446b10fbb9335d9033c54f2

We could get rid of docbook-utils too.

removing sysfsutils:
https://github.com/iputils/iputils/commit/f2060f992541b58cb0407dc95d9e40babeae76a5
Comment by Leonid Isaev (lisaev) - Thursday, 17 May 2018, 18:06 GMT
Yes, I agree about the dependencies -- somehow I missed docbook-utils and libidn2. But AFAIU, there are no new snapshots since 2016. However, there seem to be many bugfixes. so maybe we could build directly from master...

Regarding github key, I don't know. I guess the signature indicates that a commit was made using _the account_ (at github). If you believe that a successful login proves the identity of a committer, then the signature is meaningful.
Comment by Eli Schwartz (eschwartz) - Thursday, 17 May 2018, 22:25 GMT
By that logic, only the successful login can push to the repo, so everything is always trusted anytime ever.

PGP doesn't work that way, by definition it's silly (and Github is silly) to try signing on someone else's behalf.

The key is under Github's control, not the committer's control.

...

Also snapshot != release. There have been no new releases, bu we use snapshots anyway...
Comment by Hussam Al-Tayeb (hussam) - Thursday, 12 July 2018, 02:33 GMT
namcap says iputils 20180629.f6aac8d-1 doesn't depend on libsysfs but sysfsutils is marked as a dependency.

Loading...