Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#58562 - [gitlab-shell] Set autocrlf = input in gitconfig

Attached to Project: Community Packages
Opened by Jonas Hahnfeld (hahnjo) - Saturday, 12 May 2018, 15:08 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Sunday, 29 July 2018, 15:01 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The attached patch adds "autocrlf = input" to gitconfig and removes "authorized_keys" from the backup files.
   gitlab-shell.patch (2.2 KiB)
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Sunday, 29 July 2018, 15:01 GMT
Reason for closing:  Fixed
Additional comments about closing:  Closing as the original problem is fixed. Make a new issue if you care deeply about the other thing you brought up.
Comment by Doug Newgard (Scimmia) - Saturday, 12 May 2018, 16:07 GMT
With no explanation of why you think those changes need to be made. Both seem wrong to me. It also makes other changes not mentioned.
Comment by Jonas Hahnfeld (hahnjo) - Saturday, 12 May 2018, 16:20 GMT
Sorry, looks like I forgot to type the explanations that I had in my mind:
1. bundle-2.3 exec rake gitlab:check complains that the installed gitconfig is not correct and adds this setting. So I think this should be there from the beginning.
2. $ makepkg warns that the backup files I removed are not part of the package and they are somewhere else in my installation, so I think the values were just outdated.
3. You are also right that I corrected the gitconfig to be where the backup files expected it to be. I'm open to reverting that change and adding /etc/webapps/gitlab-shell/.gitconfig to the backup files.
Comment by Sven-Hendrik Haase (Svenstaro) - Monday, 14 May 2018, 09:13 GMT
From what I can see the gitconfig location, name and backup name are correct. Mind you, there is a symlink that handles this.

I will add the autocrlf stuff.

Not sure about the other backup paths, will check those out.
Comment by Jonas Hahnfeld (hahnjo) - Monday, 14 May 2018, 10:24 GMT
On my system I have $ ls -l /var/lib/gitlab/.gitconfig
lrwxrwxrwx 1 root root 36 Apr 23 21:43 /var/lib/gitlab/.gitconfig -> /etc/webapps/gitlab-shell/.gitconfig

You see, there is a '.' in front of the filename in /etc/webapps/gitlab-shell while the backup array lists etc/webapps/${pkgname}/gitconfig. I'd argue that using non-hidden files in /etc is much more convenient so I chose that path.

Loading...