FS#58546 - [gitlab] nodejs only required for make
Attached to Project:
Community Packages
Opened by Jonas Hahnfeld (hahnjo) - Friday, 11 May 2018, 14:42 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Monday, 04 June 2018, 15:54 GMT
Opened by Jonas Hahnfeld (hahnjo) - Friday, 11 May 2018, 14:42 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Monday, 04 June 2018, 15:54 GMT
|
Details
Description:
GitLab doesn't need nodejs during runtime, it's only used during installation to compile assets. Additional info: * gitlab 10.7.1-1 |
This task depends upon
I think they even go as far as not including node_modules which would save ~250MB and ~25,000 files. They also explicitly list some more directories in https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/config/software/gitlab-rails.rb#L179 which are another 6650 files. I will try to reduce the packaged files later today, looks like there is quite some potential ;-)
This environment variable needs to be added to all systemd unit files and prepended to all maintenance commands - maybe the package should have a wrapper that also sets RAILS_ENV=production?
The package built by attached patch runs fine on my server:
1. There is now an explicit dependency to http-parser which some gems are built against.
2. I've also fixed the permissions of /var/lib/gitlab/uploads as suggested by "bundle-2.3 exec rake gitlab:check"