FS#58505 - repo-remove has exit code 0 if to-be-removed package cannot be found
Attached to Project:
Pacman
Opened by Johannes Ernst (jernst) - Tuesday, 08 May 2018, 23:34 GMT
Last edited by Eli Schwartz (eschwartz) - Monday, 14 May 2018, 17:29 GMT
Opened by Johannes Ernst (jernst) - Tuesday, 08 May 2018, 23:34 GMT
Last edited by Eli Schwartz (eschwartz) - Monday, 14 May 2018, 17:29 GMT
|
Details
This should be non-0 IMHO:
% repo-remove 'some.db.tar.xz' foobar ==> Extracting database to a temporary location... ==> Extracting database to a temporary location... ==> Searching for package 'foobar'... ==> ERROR: Package matching 'foobar' not found. ==> Creating updated database file 'some.db.tar.xz' % echo $? 0 |
This task depends upon
Closed by Eli Schwartz (eschwartz)
Monday, 14 May 2018, 17:29 GMT
Reason for closing: Fixed
Additional comments about closing: https://git.archlinux.org/pacman.git/com mit/?id=0d356c27c17fb62ed31327d634748f64 c781dc49
Monday, 14 May 2018, 17:29 GMT
Reason for closing: Fixed
Additional comments about closing: https://git.archlinux.org/pacman.git/com mit/?id=0d356c27c17fb62ed31327d634748f64 c781dc49
This seems to back out the changes from https://git.archlinux.org/pacman.git/commit/?id=81d233b79345d05d5bf17a4b2844085e14f9ee36
Allan, was this intentional? It definitely doesn't look like it... we now create one variable we never use, and check another variable we never set. And the commit message is totally unrelated.