FS#58353 - [nginx] Enable more builtin modules
Attached to Project:
Arch Linux
Opened by Marius (Martchus) - Wednesday, 25 April 2018, 11:12 GMT
Last edited by Bartłomiej Piotrowski (Barthalion) - Friday, 01 June 2018, 08:44 GMT
Opened by Marius (Martchus) - Wednesday, 25 April 2018, 11:12 GMT
Last edited by Bartłomiej Piotrowski (Barthalion) - Friday, 01 June 2018, 08:44 GMT
|
Details
Description:
Could you enable [ngx_http_addition_module](http://nginx.org/en/docs/http/ngx_http_addition_module.html) which is for instance required by the fancyindex module? Additional info: See my comments under [nginx-custom](https://aur.archlinux.org/packages/nginx-custom) for the motivation behind this change. Note that I haven't checked yet whether any other modules would be required, too. In fact I would like to see a full-featured NGINX in the official repos (with full-featured I mean turn on everything NGINX provides itself, no 3rdparty modules of course). This would ease creating package for further 3rdparty modules which maybe rely on those features. Further notes: * Note that fancyindex builds fine without ngx_http_addition_module However, not all of its directives will actually work then. See https://github.com/aperezdc/ngx-fancyindex#other-platforms. * Not sure why no user of [https://aur.archlinux.org/packages/nginx-mod-fancyindex](https://aur.archlinux.org/packages/nginx-mod-fancyindex) has noticed that yet. Maybe I'm just doing something wrong after all? |
This task depends upon
Closed by Bartłomiej Piotrowski (Barthalion)
Friday, 01 June 2018, 08:44 GMT
Reason for closing: Won't implement
Additional comments about closing: In general I am open to suggestions what to enable if there is a use case, but modules for ngx-fancyindex are there, so nothing to do here.
Friday, 01 June 2018, 08:44 GMT
Reason for closing: Won't implement
Additional comments about closing: In general I am open to suggestions what to enable if there is a use case, but modules for ngx-fancyindex are there, so nothing to do here.
However, the question whether it makes sense to enable more features in general remains. Eg. in the custom package I have the following modules enabled: https://github.com/Martchus/PKGBUILDs/blob/master/nginx/custom/PKGBUILD
https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/nginx#n44
EDIT: I see
Alternatively you can also say "let's just enable everything which could possibly be useful". Shouldn't increase build time and package size significantly. Only the Perl module would require more rebuilds due to dependency to Perl libraries.
So it is up to you. Wait for feedback and close this ticked for now or just enable something by suspicion :-)