FS#58091 - archweb_get_pkgbase: urlencode pkgname to accomodate `+` characters in the pkgname

Attached to Project: Arch Linux
Opened by Andreas Grapentin (oaken-source) - Wednesday, 04 April 2018, 08:29 GMT
Last edited by Eli Schwartz (eschwartz) - Wednesday, 04 April 2018, 12:50 GMT
Task Type Bug Report
Category Arch Projects
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

archweb_get_pkgbase currently does not urlencode the pkgname, which leads to issues for split packages like libsigc++-docs which have the character '+' in the pkgname.

for example, the following fails unexpectedly:
> $ asp list-repos libsigc++-docs
> error: unknown package: libsigc++-docs

the attached patch against falconindy/asp.git master uses the --data-urlencode option of curl to correct this problem. The added -G switch to curl forces a GET request, because --data-urlencode implies a POST request by default.

Steps to reproduce:

$ asp list-repos libsigc++-docs
error: unknown package: libsigc++-docs

or directly:

$ curl https://www.archlinux.org/packages/search/json/?q=libsigc++-docs
{"num_pages": 1, "results": [], "page": 1, "version": 2, "limit": 250, "valid": true}
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Wednesday, 04 April 2018, 12:50 GMT
Reason for closing:  Upstream
Additional comments about closing:  https://github.com/falconindy/asp

Loading...