Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#58055 - [gitlab] set StartLimitIntervalSec in the service files

Attached to Project: Community Packages
Opened by Jakub Klinkovský (lahwaacz) - Saturday, 31 March 2018, 21:43 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Saturday, 07 April 2018, 03:24 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

The gitlab service files set Restart=on-failure and RestartSec=1, but StartLimitIntervalSec and StartLimitBurst are left to the default (the defaults in system.conf are DefaultStartLimitIntervalSec=10s and DefaultStartLimitBurst=100ms).

Given that the gitlab services usually take a couple of seconds to start up, this can easily lead to a situation where the services are restarted over and over without triggering the limit. Since RestartSec is set 10x the default in the service files, I suggest to set StartLimitIntervalSec=100s in the services as well to match the default limiting logic.
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Saturday, 07 April 2018, 03:24 GMT
Reason for closing:  Fixed
Comment by Sven-Hendrik Haase (Svenstaro) - Monday, 02 April 2018, 01:29 GMT
Good suggestion.
Comment by Jakub Klinkovský (lahwaacz) - Thursday, 05 April 2018, 14:57 GMT
StartLimitIntervalSec= belongs to the [Unit] section, not [Service].
Comment by Sven-Hendrik Haase (Svenstaro) - Friday, 06 April 2018, 11:55 GMT
Can you check now?
Comment by Jakub Klinkovský (lahwaacz) - Friday, 06 April 2018, 17:14 GMT
systemd doesn't complain anymore...

Loading...