FS#58054 - [restbed] catch2 is a makedepend, not a checkdepend

Attached to Project: Community Packages
Opened by Kevin Mihelich (kmihelich) - Saturday, 31 March 2018, 21:42 GMT
Last edited by Baptiste (zorun) - Monday, 02 April 2018, 11:28 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Baptiste (zorun)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description: Checkdepends are being used as makedepends. With -DBUILD_TESTS=on, catch2 is required to be present for cmake to configure successfully.


Additional info:
* package version: 4.6+24+gb1f0182-2
* log:
CMake Error at cmake/modules/Findcatch.cmake:10 (message):
Failed to locate Catch dependency.
Call Stack (most recent call first):
CMakeLists.txt:68 (find_package)


-- Configuring incomplete, errors occurred!


Steps to reproduce: Build in a clean chroot with the --nocheck option to makepkg.
This task depends upon

Closed by  Baptiste (zorun)
Monday, 02 April 2018, 11:28 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in restbed 4.6+28+gc3a259b-1
Comment by Baptiste (zorun) - Monday, 02 April 2018, 09:53 GMT
Well, I can move catch2 to makedepends, but then 90% of the build time is spent on building tests, so running with --nocheck would wastefully build tests without running them.

It seems that well-behaved packages automatically enable tests when the required dependencies are present, I'll see if it's possible here.
Comment by Baptiste (zorun) - Monday, 02 April 2018, 11:28 GMT
Fixed (and patch sent upstream), restbed now only builds tests if catch2 is installed.

Loading...