FS#58003 - [emacs-php-mode] needs !makeflags option to prevent concurrency
Attached to Project:
Community Packages
Opened by Kevin Mihelich (kmihelich) - Wednesday, 28 March 2018, 13:57 GMT
Last edited by Sergej Pupykin (sergej) - Friday, 22 June 2018, 16:29 GMT
Opened by Kevin Mihelich (kmihelich) - Wednesday, 28 March 2018, 13:57 GMT
Last edited by Sergej Pupykin (sergej) - Friday, 22 June 2018, 16:29 GMT
|
Details
Description: Multi-threaded builds of this package do not
appear to be safe. There is a race condition such that a
parallel make causes a needed file to be locked, stalling
the build. Supplying the !makeflags option to prevent
concurrency solves the problem.
Additional info: * package version: 1.19.0-1 * log snippet: Generating autoloads for php-mode.el...done Generating autoloads for php-mode.el... Generating autoloads for php-project.el... Generating autoloads for php-project.el...done Saving file /build/emacs-php-mode/src/php-mode-1.19.0/php-mode-autoloads.el... .../php-mode-autoloads.el locked by builduser@lem... (pid 1259): (s, q, p, ?)? Steps to reproduce: Build with MAKEFLAGS -j > 1. This will not fail every time. |
This task depends upon
If someone wishes to use other flags with Make we shouldn't prevent that. Just override the one thing which needs to be changed.
...
Have you filed an upstream bug to fix this? I don't see one: https://github.com/ejmr/php-mode/issues
But I don't understand why we're running make at all, since we don't even package the resulting byte-compiled *.elc files or php-mode-autoloads.el