FS#57810 - [xorg-xinit] sed bad syntax

Attached to Project: Arch Linux
Opened by lucenera (lucenera) - Monday, 12 March 2018, 21:06 GMT
Last edited by Andreas Radke (AndyRTR) - Saturday, 17 March 2018, 12:54 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Andreas Radke (AndyRTR)
Architecture x86_64
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
when I run the startx command, I get the following warning:
sed: -e expression # 1, char 52: unknown option to 's'.

Additional info:
* xorg-xinit 1.4.0-1 [testing]
* .xinitrc:
[[ -f ~/.Xresources ]] && xrdb -merge -I$HOME ~/.Xresources

if [ -d /etc/X11/xinit/xinitrc.d ] ; then
for f in /etc/X11/xinit/xinitrc.d/?*.sh ; do
[ -x "$f" ] && . "$f"
done
unset f
fi

exec i3

Steps to reproduce:
bash in user's shell: issue 'startx' command.
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Saturday, 17 March 2018, 12:54 GMT
Reason for closing:  Fixed
Comment by Andreas Radke (AndyRTR) - Tuesday, 13 March 2018, 16:38 GMT
Please try 1.4.0-2 with the fs25361 patch reverted to last status.
Comment by lucenera (lucenera) - Tuesday, 13 March 2018, 20:11 GMT
For me the bug is solved by updating to version 1.4.0-2. Thank you.
Comment by stef204 (stef204) - Wednesday, 14 March 2018, 20:42 GMT
  • Field changed: Percent Complete (100% → 0%)
there us another (I believe) related error possibly created by the same fs25361 patch.
Comment by stef204 (stef204) - Wednesday, 14 March 2018, 20:56 GMT
I believe this may be related to fs25361.patch.
While the fix above did remove the sed error, I am still getting: xauth: file /home/user/.serverauth.9006 does not exist (the number 9006 changes with each start x.)

Prior to 1.4.0-1 and now 1.4.0-2, so up to 1.3.4-4, it seems the serverauth.* file was created in /tmp
Since 1.4+, it is created in $HOME. However, xorg may still be looking for that file in /tmp and not seeing it, give off the "xauth: file /home/user/.serverauth.9006 does not exist"

I can file a separate bug for this issue if more appropriate, but fs25361.patch may be causing this as well.
Comment by Andreas Radke (AndyRTR) - Friday, 16 March 2018, 09:44 GMT
This doesn't make sense. Check all the commits to the 1.4.0 release. There's no change related to that location.

https://cgit.freedesktop.org/xorg/app/xinit/commit/?h=xinit-1.4.0&id=e07fa99039c0f63ed8f0b142e546ef102321fca0 - that's the only touching it and doesn't change it to homedir.

Comment by stef204 (stef204) - Friday, 16 March 2018, 20:37 GMT
@AndyRTR
I might have spoken too quickly re. the fs25361.patch causing this error -> "xauth: file /home/user/.serverauth.9006 does not exist" (Note: the number 9006 changes with each start x.)
But I can assure that it is there on each "startx" since moving from 1.3.4-4 to 1.4+.
And I have checked for the .serverauth* file, in both /tmp and $HOME. on the 3 versions mentioned. It appears in $HOME only starting with 1.4+. At least, on my box. Please see here:
<https://git.archlinux.org/svntogit/packages.git/commit/trunk?h=packages/xorg-xinit&id=2575760c14fee29ed426cae721e6326b7d374ef3>
It could be due to something else wrongly configured on my box, but frankly, seeing it run very clean on 1.3.4-4; I'm not sure the cause is "local".
I could also open a new bug so this one can be closed, if that is better. Please let me know.
Comment by Andreas Radke (AndyRTR) - Saturday, 17 March 2018, 07:44 GMT
I guess the patch didn't apply cleanly before the other patches were fixed. I've brought the 06_move_serverauthfile_into_tmp.diff back. Please test 1.4.0-3.
Comment by stef204 (stef204) - Saturday, 17 March 2018, 12:50 GMT
Looks fixed with 1.4.0-3 in testing; nice and clean.

Loading...