FS#57445 - [rust] use /usr/share/bash-completions/completion

Attached to Project: Community Packages
Opened by Colin Arnott (arnottcr) - Friday, 09 February 2018, 11:13 GMT
Last edited by Johannes Löthberg (demize) - Thursday, 29 March 2018, 14:23 GMT
Task Type General Gripe
Category Upstream Bugs
Status Closed
Assigned To Johannes Löthberg (demize)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


I noticed recently that the rust package is storing bash completion for cargo in /etc/bash_completions.d/; based on my understanding this is non-standard: see https://www.archlinux.org/todo/use-usrsharebash-completioncompletions-for-package-bash-completions/

I looked through the PKGBUILD, but was unclear where this was being added; I am happy to supply a diff that would move it around in $pkgdir at the end of the package_rust() function, but I thought I would reach out first.

Additional info:
* package version: rust-1:1.23.0-3
This task depends upon

Closed by  Johannes Löthberg (demize)
Thursday, 29 March 2018, 14:23 GMT
Reason for closing:  Fixed
Additional comments about closing:  1:1.25.0-1
Comment by Eli Schwartz (eschwartz) - Friday, 09 February 2018, 15:02 GMT
  • Field changed: Status (Unconfirmed → Assigned)
  • Field changed: Category (Packages → Upstream Bugs)
  • Task assigned to Johannes Löthberg (demize)
This is how upstream's build system does things: https://github.com/rust-lang/rust/blob/master/src/bootstrap/dist.rs#L1027

Please file an upstream bug to use `pkg-config bash-completion --variable=completionsdir` when available.