Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#57171 - [simplescreenrecorder] missing translation files

Attached to Project: Community Packages
Opened by Andrew Shark (ashark) - Saturday, 20 January 2018, 10:12 GMT
Last edited by Kyle Keen (keenerd) - Tuesday, 30 January 2018, 12:42 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Kyle Keen (keenerd)
Architecture x86_64
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

simplescreenrecorder package version 0.3.9-1 do not contain qm files in
/usr/share/simplescreenrecorder/translations/
So application appears only in english interface.
In version 0.3.8-1 these files were in place.

I have rebuild package by myself and there was that subdirectory with qm files. So it is not upstream problem.
I think possible reason could be that cmake did not find an lrelease binary while building.
Here is checking for lrelease:
https://github.com/MaartenBaert/ssr/commit/699dd22e6d2fc9f3a89baf26672e6ed230a69f7f#diff-a804866f29638f002e9f5a60d1d0cf98R2

pkgfile lrelease returned qt4 and qt5-tools.
I have both, but in your .BUILDINFO qt5-tools package is absent. So this may be the reason.


Additional info:
* package version 0.3.9-1
This task depends upon

Closed by  Kyle Keen (keenerd)
Tuesday, 30 January 2018, 12:42 GMT
Reason for closing:  Fixed
Additional comments about closing:  simplescreenrecorder 0.3.9-2
Comment by Eli Schwartz (eschwartz) - Sunday, 21 January 2018, 03:21 GMT
Since we build against qt4, we should be using lrelease-qt4.
Comment by Andrew Shark (ashark) - Sunday, 21 January 2018, 07:43 GMT
Lets see what we have in archlinux:
$ pacman -Ql qt4 | grep lrelease
qt4 /usr/bin/lrelease-qt4 (symlink to /usr/lib/qt4/bin/lrelease)
qt4 /usr/lib/qt4/bin/lrelease
$ pacman -Ql qt5-tools | grep lrelease
qt5-tools /usr/bin/lrelease
qt5-tools /usr/bin/lrelease-qt5 (symlink to /usr/bin/lrelease)

So in src/translations/CMakeLists.txt I suggest to change line 3 in upstream.
find_program(LRELEASE lrelease)
There is already WITH_QT5 option exist in a project, so we can do something like this:
if(WITH_QT5)
find_program(LRELEASE lrelease-qt5)
else()
find_program(LRELEASE lrelease-qt4)
endif()
or
if(WITH_QT5)
find_program(LRELEASE lrelease /usr/bin/)
else()
find_program(LRELEASE lrelease /usr/lib/qt4/bin/)
endif()

Also I wanted to mention that in CMakeCache.txt there is already line
QT_LRELEASE_EXECUTABLE:FILEPATH=/usr/lib/qt4/bin/lrelease
so maybe we need use this instead?
Comment by Michał Walenciak (Kicer) - Thursday, 25 January 2018, 18:51 GMT
I'm not sure if there should be any changes made in ssr's CMakeFiles.
lrelease's name may be inconsistent across linux distros, so it may be very difficult to find an universal solution.
What about patch in aur?
Comment by Kyle Keen (keenerd) - Tuesday, 30 January 2018, 12:42 GMT
Interesting, it produces the translation files when I build outside of a chroot, presumably using Qt5's lrelease. Easy to fix though.

Loading...