FS#57121 - [libffado] Menu entry icon not displayed

Attached to Project: Community Packages
Opened by lukpod (lukpod) - Tuesday, 16 January 2018, 21:03 GMT
Last edited by David Runge (dvzrv) - Wednesday, 17 January 2018, 12:13 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Ray Rashif (schivmeister)
David Runge (dvzrv)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

$ grep Icon /usr/share/applications/ffadomixer.desktop
Icon=hi64-apps-ffado

$ pacman -Qlq libffado | grep -e hi64-apps-ffado -e pixmaps -e icons
/usr/share/libffado/icons/
/usr/share/libffado/icons/hi64-apps-ffado.png
/usr/share/pixmaps/
/usr/share/pixmaps/ffado.png
This task depends upon

Closed by  David Runge (dvzrv)
Wednesday, 17 January 2018, 12:13 GMT
Reason for closing:  Fixed
Additional comments about closing:  Although 2.4.0-3 fixes this issue, a better way of dealing with XDG_DATA_DIRS will be requested upstream.
Also, the icon file naming is just wrong...
Comment by Eli Schwartz (eschwartz) - Tuesday, 16 January 2018, 21:39 GMT
http://subversion.ffado.org/changeset/2627

FWIW, the whole mess with "xdg tools cannot cope with DESTDIR" can be solved by using
`XDG_DATA_DIRS="${pkgdir}/usr/share" buildsystem install DESTDIR="${pkgdir}"`
(Note that xdg utils are finicky and may require creating some directories beforehand.)

See for example how I historically fixed the calibre PKGBUILD.
Someone might want to consider contacting libffado upstream and convincing them to set XDG_DATA_DIRS based on DESTDIR instead of arbitrarily refusing to implement the installation of xdg stuff.
Comment by David Runge (dvzrv) - Wednesday, 17 January 2018, 10:57 GMT
@eschwartz: thanks for the input!
I'm currently in contact with upstream anyways and will reqeust this.

Loading...