FS#57060 - [devtools] diff-so-fancy build fails if run in urxvt terminal

Attached to Project: Arch Linux
Opened by Erich Eckner (deepthought) - Friday, 12 January 2018, 08:42 GMT
Last edited by Toolybird (Toolybird) - Sunday, 01 January 2023, 23:23 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Pierre Schmitz (Pierre)
Bartłomiej Piotrowski (Barthalion)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

The build in a clean chroot with extra-x86_64build fails in check() if run in a urxvt terminal with:

==> Starting check()...
Initialized empty Git repository in /build/diff-so-fancy/src/diff-so-fancy-1.0.0/.git/
tput: unknown terminal "rxvt-unicode-256color"
Argument "" isn't numeric in repeat (x) at /build/diff-so-fancy/src/diff-so-fancy-1.0.0/test/../diff-so-fancy line 450, <$cmd_output> line 2.
/usr/lib/bats/bats-exec-suite: line 20: let: count+=: syntax error: operand expected (error token is "+=")
==> ERROR: A failure occurred in check().

It looks like my terminal is leaked into the build environment. Running
TERM=xterm extra-x86_64-build
works. Maybe you should export TERM=xterm in check() - or apply the patch in the attachment?

Additional info:
* package version(s)
diff-so-fancy 1.0.0 (git revision 37952667913642f93f0322d466de41ab02850dd6)

Steps to reproduce:
> urxvt -e extra-x86_64-build
alternative:
> TERM=rxvt-unicode-256color extra-x86_64-build
   term.diff (0.4 KiB)
This task depends upon

Closed by  Toolybird (Toolybird)
Sunday, 01 January 2023, 23:23 GMT
Reason for closing:  Works for me
Additional comments about closing:  I cannot reproduce this and assume it's been fixed upstream in diff-so-fancy. Please request reopen if you can still repro.
Comment by Erich Eckner (deepthought) - Friday, 12 January 2018, 09:08 GMT
On second thought, that might (also) be an issue of devtools.
Comment by Doug Newgard (Scimmia) - Sunday, 21 January 2018, 02:12 GMT
It's either a systemd-nspawn issue or something that needs to be dealt with in devtools. You can't guarantee the terminfo is available inside the container for any random TERM that's set.

Loading...