FS#56984 - [valgrind] binaries are not striped

Attached to Project: Arch Linux
Opened by lilydjwg (lilydjwg) - Sunday, 07 January 2018, 03:49 GMT
Last edited by Bartłomiej Piotrowski (Barthalion) - Sunday, 07 January 2018, 13:46 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Bartłomiej Piotrowski (Barthalion)
Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Today with valgrind 3.13.0-6, it's 182.56 MiB larger than 3.13.0-4. It's because stripping is disabled. The commit message says "strip only the binaries" but actually nothing gets striped due to lack of space between "{}+".

The binaries in /usr/bin aren't large though. The large ones are in /usr/lib/valgrind and they are statically linked. I don't know what issues stripping has caused but I suppose those static binaries can be striped too?

$ file /usr/lib/valgrind/* | grep 'executable.*statically linked' | cut -d: -f1 | wc -l
22
$ file /usr/lib/valgrind/* | grep 'executable.*statically linked' | cut -d: -f1 | xargs du -shc | tail -1
186M total
$ file /usr/lib/valgrind/* | grep 'executable.*statically linked' | cut -d: -f1 | xargs cp -t . && strip * && du -sh .
46M .

It's 140M less.
This task depends upon

Closed by  Bartłomiej Piotrowski (Barthalion)
Sunday, 07 January 2018, 13:46 GMT
Reason for closing:  Fixed
Comment by Eli Schwartz (eschwartz) - Sunday, 07 January 2018, 04:18 GMT
Also should probably be guarded with the same checks implemented in the glibc package.
Comment by Bartłomiej Piotrowski (Barthalion) - Sunday, 07 January 2018, 13:46 GMT
We're basically following upstream recommendation saying that we shouldn't strip these files – so we don't anymore. At least for dynamic libraries traces were less useful.

I fixed binaries stripping in trunk, it doesn't save much so I didn't push a new package.

Loading...