Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#56979 - [libupnp] programs compiled against libupnp 1.6.24-1 crash with segv

Attached to Project: Arch Linux
Opened by jason (ortango) - Saturday, 06 January 2018, 21:17 GMT
Last edited by Jelle van der Waa (jelly) - Thursday, 11 January 2018, 19:13 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Jelle van der Waa (jelly)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: the 1.6.24 release of libupnp is buggy. leading to an immediate crash when using programs built with it.

Additional info:
* 1.6.24-1
* relevant links explain the problem and solution much more.
debian bug report https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883118
partial patch upstream https://github.com/mrjimenez/pupnp/commit/70e3d626378e12ea50d76dfda50311c8bb4a2a78#diff-fbf6161f67b9ee4e0ac8f5c0d8cac26b

Steps to reproduce:

build a libupnp program with 1.6.24-1 (eg: gmrender-resurrect-git, upmpdcli) and try to connect to a upnp media server on the network (run gmediarender with a server running).
gmrender will crash with seg fault after connection.

the debian libupnp6 bug report link contains all the valid info, and a patch. applying the patch to httpreadwrite.c from the upstream link, and the patch to webserver.c from the debian bug report fixes this bug.
debian has released a patched libupnp6 in this fashion.

i'd be happy to provide debug logs here if that is necessary.
This task depends upon

Closed by  Jelle van der Waa (jelly)
Thursday, 11 January 2018, 19:13 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in 1.6.24-2
Comment by Jelle van der Waa (jelly) - Tuesday, 09 January 2018, 20:08 GMT
I can't reproduce the issue with minidlnad and starting gmediarender:

[jelle@helium][/tmp/mediatomb]%gmediarender
gmediarender 0.0.7-git started [ gmediarender 2017-12-10_704b182 (libupnp-1.6.24; glib-2.54.0; gstreamer-1.12.4) ].
Logging switched off. Enable with --logfile=<filename> (e.g. --logfile=/dev/stdout for console)
Ready for rendering.

I'm fine with including the upstream patch, but why is the Debian patch not upstream?
Comment by jason (ortango) - Tuesday, 09 January 2018, 23:49 GMT
you know i could have sworn i had tried building with just the upstream patch and was still crashing. but i was mistaken, with just the upstream patch i'm running fine.
so i'm not sure if the patch is needed, but debian did include it. from my end i'd say just ignore it, as you did (thanks for the quick update).

your reproduction attempt: was that was with 1.6.24-1? or testing the upstream patch?
Comment by Jelle van der Waa (jelly) - Wednesday, 10 January 2018, 07:59 GMT
I couldn't reproduce it without the patch, but it might be that just running minidlnad without configuration wasn't enough. I don't run a UPNP server and just bumped the library.

So if this fixes the segfault I'll close the ticket.
Comment by jason (ortango) - Wednesday, 10 January 2018, 22:33 GMT
yes it does, thanks again.

Loading...