FS#56853 - [systemtap] Can't make SystemTap work on Linux 4.14.7 and 4.14.8.

Attached to Project: Community Packages
Opened by Dmitry (funbringer) - Monday, 25 December 2017, 11:36 GMT
Last edited by Christian Rebischke (Shibumi) - Wednesday, 14 February 2018, 11:27 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Christian Rebischke (Shibumi)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Description:

Can't make SystemTap work on Linux 4.14.7 and 4.14.8:

WARNING: Kernel function symbol table missing [man warning::symbols]
In file included from /usr/share/systemtap/runtime/stp_utrace.c:30:0,
from /usr/share/systemtap/runtime/linux/task_finder2.c:4,
from /usr/share/systemtap/runtime/linux/task_finder.c:17,
from /usr/share/systemtap/runtime/linux/runtime.h:222,
from /usr/share/systemtap/runtime/runtime.h:26,
from /tmp/stapEZTrbW/stap_51f64e0f727881b4e5ec902390a5003b_944_src.c:25:
/usr/share/systemtap/runtime/stp_helper_lock.h: В функции «stp_spin_unlock_wait»:
/usr/share/systemtap/runtime/stp_helper_lock.h:60:61: ошибка: implicit declaration of function «spin_unlock_wait»; did you mean «stp_spin_unlock_wait»? [-Werror=implicit-function-declaration]
static inline void stp_spin_unlock_wait(spinlock_t *lock) { spin_unlock_wait(lock); }
^~~~~~~~~~~~~~~~
stp_spin_unlock_wait


Additional info:
* systemtap 3.1-5
* linux 4.14.8


Steps to reproduce:

1) Use one of the scripts attached (e.g. hello_world.d)
2) Run sudo stap __script_name__
3) See the compilation error
This task depends upon

Closed by  Christian Rebischke (Shibumi)
Wednesday, 14 February 2018, 11:27 GMT
Reason for closing:  Won't fix
Additional comments about closing:  systemtap will be moved back to AUR
Comment by Dmitry (funbringer) - Monday, 25 December 2017, 11:44 GMT
UPDATE: I DO understand that this package is outdated, but it's been so for ~12 days. I hope that this bug will draw some attention.
Comment by Christian Rebischke (Shibumi) - Monday, 25 December 2017, 18:42 GMT
Hello,
I am the maintainer. I hadn't time yet to look over it because of compilation errors. If you want to help out, you are welcome.
Comment by Dmitry (funbringer) - Monday, 25 December 2017, 19:09 GMT
Hi, Christian,
Thanks for the quick response! I see, so that's the problem. Ok, I'll give it a try.
Comment by Dmitry (funbringer) - Tuesday, 26 December 2017, 11:19 GMT
Hi again,

Here's a small patch that fixes broken builds caused by install-exec-hook in stapbpf/Makefile.am & staprun/Makefile.am. I also decided to add missing groups for stapbpf & staprun, but I may be wrong here.

However, here's a few questions:
1) Should we install stap-server.service? It might be a good idea.
2) Also, should we add a group fro stap-server?
3) I haven't checked the patches you apply to sources, do we still need them?
4) Should we split this package into several packages? (the way they do in RPM spec file)

P.S. I'm new to Arch packages, hope this helps.
Comment by Eli Schwartz (eschwartz) - Tuesday, 26 December 2017, 15:31 GMT
1) see https://www.archlinux.org/todo/switch-to-systemd-sysusers/

You should chgrp 156 the binaries in package(), and use a sysusers.d(5) configuration file to create the extra users.

2) Consider filing an upstream bug for this.

3) Arch does not typically split packages without highly specific reasons, "because RPM does it" is not any reason at all. :p What would be the advantage of doing so, if any?
Comment by Christian Rebischke (Shibumi) - Saturday, 27 January 2018, 03:11 GMT
@Dmitry
Please keep in mind that you still need to recompile the kernel. Our current kernel doesn't have the CONFIG_DEBUG_INFO flag enabled. This is still on my todolist

I am not a fan of split packages as well. But i like the idea of the optional dependencies.
Comment by Christian Rebischke (Shibumi) - Wednesday, 14 February 2018, 11:27 GMT
I am going to move systemtap to the AUR today, due to missing dependencies.

Loading...