Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#56822 - [gopass] PKGBUILD installs bash completion for zsh and vice versa

Attached to Project: Community Packages
Opened by Maxim Baz (maximbaz) - Friday, 22 December 2017, 16:16 GMT
Last edited by Morten Linderud (Foxboron) - Wednesday, 03 January 2018, 15:30 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Morten Linderud (Foxboron)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Here's the relevant snippet from the current PKGBUILD (1.6.5-2):

install -Dm644 bash.completion "${pkgdir}/usr/share/zsh/site-functions/_${pkgname}"
install -Dm644 zsh.completion "${pkgdir}/usr/share/bash/completions/${pkgname}"

As you can see, bash.completion gets installed in the zsh folder, while zsh.completion gets into the bash folder.

I actually noticed that even after fixing this bug locally the completion still didn't work for me in zsh, I had to run `$ source /usr/share/zsh/site-functions/_gopass` to get working, and I have to do it every time I open a new terminal. I'm not sure what exactly the problem is, but other completions seem to work fine (like for pass), the problem is only with gopass completion.
This task depends upon

Closed by  Morten Linderud (Foxboron)
Wednesday, 03 January 2018, 15:30 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with 1.6.7
Comment by Morten Linderud (Foxboron) - Friday, 22 December 2017, 19:56 GMT
Awkward copypasta. The zsh completion is however fucked from upstream as they assume you are going to source the file and not package it properly. I'll look into how to fix it and possibly fix it upstream whenever i have the opportunity over christmas.
Comment by Eli Schwartz (eschwartz) - Sunday, 24 December 2017, 02:29 GMT
source <(gopass completion bash)

I think it is fair to say that they do not actually offer zsh completions at all. :(
Comment by Morten Linderud (Foxboron) - Sunday, 24 December 2017, 11:41 GMT
Been working to fix it upstream
https://github.com/justwatchcom/gopass/pull/560#issuecomment-353771256

Loading...