FS#56783 - Regression: Can't pin comments on packages I maintain

Attached to Project: AUR web interface
Opened by Chih-Hsuan Yen (yan12125) - Wednesday, 20 December 2017, 04:03 GMT
Last edited by Eli Schwartz (eschwartz) - Saturday, 23 December 2017, 23:09 GMT
Task Type Bug Report
Category Backend
Status Closed
Assigned To Eli Schwartz (eschwartz)
Architecture All
Severity Medium
Priority Normal
Reported Version 4.6.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

This is a following up of  FS#56255 . With AUR 4.6.0, I can pin comments on packages that I'm a co-maintainer (e.g. dropbox), but can't on those I maintain (e.g. webkitgtk). I believe it's a regression after https://git.archlinux.org/aurweb.git/commit/?id=8c98db0b82cc85a4498589e5d60299fefd93b421.
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Saturday, 23 December 2017, 23:09 GMT
Reason for closing:  Fixed
Additional comments about closing:  https://git.archlinux.org/aurweb.git/com mit/?id=ac29097ce8
Comment by Eli Schwartz (eschwartz) - Wednesday, 20 December 2017, 04:19 GMT
o_O I could swear I sent an email about this to aur-dev.

In fact, my email account actually lists me as having sent one, but this was around when I switched computers and had to reconfigure Thunderbird, so I accidentally managed to send it using the email address that isn't subscribed to the mailing list, so it failed to go through. *headdesk* I guess now I know why Lukas never responded in any way.

Sorry...
Comment by Chih-Hsuan Yen (yan12125) - Wednesday, 20 December 2017, 04:27 GMT
Don't worry :) More eyes just make Arch Linux better.
Comment by Eli Schwartz (eschwartz) - Wednesday, 20 December 2017, 05:00 GMT
Lesson for today -- we need better instructions for actually testing a proper aurweb setup, so I can actually test package pages. :(

Currently I just get lots of "Error - Could not connect to AUR database".
Comment by Lukas Fleischer (lfleischer) - Wednesday, 20 December 2017, 06:58 GMT
Did you check the TESTING document [1] in the source tree...?

[1] https://git.archlinux.org/aurweb.git/plain/TESTING
Comment by Eli Schwartz (eschwartz) - Wednesday, 20 December 2017, 07:26 GMT
Yes, using $repodir/aurweb.sqlite3 and conf/config with name = aurweb.sqlite3, backend = sqlite

Not really familiar enough with e.g. mariadb to even do more than abortive attempts at a proper INSTALL.

(I did try, but mysql -uaur -p AUR </srv/http/aurweb/schema/aur-schema.sql errored with ERROR 1071 (42000) at line 20: Specified key was too long; max key length is 767 bytes.)
Comment by Lukas Fleischer (lfleischer) - Wednesday, 20 December 2017, 07:31 GMT
Ah, you need to install the config file to `/etc/aurweb/config`, see 8586679 (Move configuration to /etc/aurweb/config, 2016-10-17) for details. We should update our documentation...
Comment by Eli Schwartz (eschwartz) - Wednesday, 20 December 2017, 07:33 GMT
Isn't that what export AUR_CONFIG=$(pwd)/conf/config is for?
Comment by Remy Marquis (Spyhawk) - Thursday, 21 December 2017, 01:46 GMT
eschwartz, lukas> If following the TESTING instructions, enabling the pdo_sqlite3 extension in PHP.ini is required. The sqlite3 extension won't work. Didn't took time yet to send a patch yet.
Comment by Eli Schwartz (eschwartz) - Thursday, 21 December 2017, 03:29 GMT
That got it working, and I was able to shove enough echo statements into the PHP to figure out what the problem was.

https://lists.archlinux.org/pipermail/aur-dev/2017-December/004406.html
Comment by Chih-Hsuan Yen (yan12125) - Thursday, 21 December 2017, 03:46 GMT
Thanks for the fix, Eli Schwartz. How about adding tests for both cases (maintainers can pin comments & co-maintainers can pin comments)?
Comment by Eli Schwartz (eschwartz) - Thursday, 21 December 2017, 03:52 GMT
I'm not even sure how we'd add tests for the PHP, currently we only really do tests for the database and ssh/python authentication.
Comment by Eli Schwartz (eschwartz) - Saturday, 23 December 2017, 23:05 GMT
Now fixed in master via https://git.archlinux.org/aurweb.git/commit/?id=ac29097ce8585b99ebe7c5d9570b0567236d45f3 and the live aurweb instance has been patched, so pinning works again.

Loading...