FS#56628 - [drupal] Drupal 8 doesn't support PHP 7.2, adapt requirements

Attached to Project: Community Packages
Opened by Tom Debruyne (tdebruyn) - Friday, 08 December 2017, 08:08 GMT
Last edited by Doug Newgard (Scimmia) - Friday, 09 March 2018, 16:28 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details
This task depends upon

Closed by  Doug Newgard (Scimmia)
Friday, 09 March 2018, 16:28 GMT
Reason for closing:  Fixed
Comment by Tom Debruyne (tdebruyn) - Friday, 22 December 2017, 10:14 GMT
It seems like there will not be support for PHP 7.2 with Drupal 8.4 : https://www.drupal.org/project/drupal/issues/2932574
Drupal 8.5 is only scheduled for March 2018 (https://www.drupal.org/core/release-cycle-overview), until then, it would be convenient to create php71 and php-gd71 packages and have drupal package depending on them.
Comment by Sergej Pupykin (sergej) - Tuesday, 09 January 2018, 17:24 GMT
I've put php71*packages to community-testing, could you please check if it works?
Comment by Sergej Pupykin (sergej) - Tuesday, 09 January 2018, 18:14 GMT
I updated php71, drupal, nextcloud in community-testing
Comment by Tom Debruyne (tdebruyn) - Tuesday, 09 January 2018, 20:25 GMT
I have faced 2 problems:
1. php-apache should also be version 7.1
2. /etc/php/php.ini got overwritten

When reverting php-apache to the old version and replacing php.ini with an old backup, the site works well with drupal 8.4.4, php71 and php-gd71.
Thanks!
Comment by Sergej Pupykin (sergej) - Tuesday, 09 January 2018, 20:36 GMT
1 - yes, but adding php-apache to drupal deps is incorrect

2 - you should restore it manually from .pacsave file, I think it cannot be fixed in current pacman.
Comment by Eli Schwartz (eschwartz) - Tuesday, 09 January 2018, 20:45 GMT
1) It might be appropriate, at least for split packages like this, to depend on an exact version of php for the subpackages. This is what the gcc package does, for example. But that would primarily have to be fixed in the [extra]/php package, and is a separate issue.

2) etc/php/php.ini should not be overwritten, removing one package that conflicts with another creates a pacsave and then creates a php.ini where there was none.

In theory, pacman could be taught to recognize when a package that conflicts/provides another package also provides the same backup file, and simply leave it in place the whole time. But there could be legitimate reasons why the file needs to be replaced, so I'm not sure that is actually a *good* idea.
Comment by Levente Polyak (anthraxx) - Tuesday, 20 February 2018, 10:59 GMT
once we have drupal that supports php 7.3 please kill php71 with lots of fire!

Loading...