Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#56599 - [gitlab-workhorse] unrecognized argument in gitlab-workhorse.service

Attached to Project: Community Packages
Opened by Jakub Klinkovský (lahwaacz) - Tuesday, 05 December 2017, 17:52 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Thursday, 07 December 2017, 19:20 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The default gitlab-workhorse.service has this ExecStart line [1]:

ExecStart=/usr/bin/gitlab-workhorse -listenUmask 0 -authBackend http://localhost:8080 -authSocket /var/lib/gitlab/sockets/gitlab.socket -listenAddr /run/gitlab/gitlab-workhorse.socket -listenNetwork unix /var/lib/gitlab/repositories -documentRoot /usr/share/webapps/gitlab/public

There is "/var/lib/gitlab/repositories" near the end, but what option does it belong to? The gitlab-workhorse does not have any (documented) positional arguments, so it might be just ignored. Is it a typo?

[1] https://git.archlinux.org/svntogit/community.git/tree/trunk/gitlab-workhorse.service?h=packages/gitlab-workhorse#n15
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Thursday, 07 December 2017, 19:20 GMT
Reason for closing:  Fixed
Comment by Eli Schwartz (eschwartz) - Tuesday, 05 December 2017, 19:29 GMT
It used to be at the end, until it was switched in  FS#49201 . But that's been there since the first version.
Comment by Jakub Klinkovský (lahwaacz) - Tuesday, 05 December 2017, 20:21 GMT
Well, the current lib/support/init.d/gitlab.default.example contains just this:

gitlab_workhorse_options="-listenUmask 0 -listenNetwork unix -listenAddr $socket_path/gitlab-workhorse.socket -authBackend http://127.0.0.1:8080 -authSocket $socket_path/gitlab.socket -documentRoot $app_root/public"
Comment by Jakub Klinkovský (lahwaacz) - Tuesday, 05 December 2017, 20:25 GMT
Also note that I found it partly because I added "-logFile /var/lib/gitlab/log/workhorse.log" at the end of ExecStart and it didn't work, but it worked when I added it at the beginning. Maybe the command line parser got confused after all...
Comment by Sven-Hendrik Haase (Svenstaro) - Wednesday, 06 December 2017, 10:11 GMT
Uh, so do I close this or what? If we go by this line: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/support/init.d/gitlab#L43 then the service file is correct.
Comment by Jakub Klinkovský (lahwaacz) - Wednesday, 06 December 2017, 15:42 GMT
I still don't see where the /var/lib/gitlab/repositories path comes from - nothing similar is used anywhere in that init script.

If I followed the right link, upstream has these options:
-listenUmask 0 -listenNetwork unix -listenAddr $socket_path/gitlab-workhorse.socket -authBackend http://127.0.0.1:8080 -authSocket $rails_socket -documentRoot $app_root/public"

Arch service file:
-listenUmask 0 -authBackend http://localhost:8080 -authSocket /var/lib/gitlab/sockets/gitlab.socket -listenAddr /run/gitlab/gitlab-workhorse.socket -listenNetwork unix /var/lib/gitlab/repositories -documentRoot /usr/share/webapps/gitlab/public

All options except /var/lib/gitlab/repositories nicely match each other.
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 07 December 2017, 02:14 GMT
Ok, the line should be synced now.
Comment by Jakub Klinkovský (lahwaacz) - Thursday, 07 December 2017, 18:37 GMT
Good, so feel free to close this when the new package is released.

Loading...