FS#56592 - [libmicrohttpd] 0.9.57 do not have 'curl' or 'file' dependencies

Attached to Project: Community Packages
Opened by Evgeny Grin (Karlson2k) - Tuesday, 05 December 2017, 14:47 GMT
Last edited by Christian Hesse (eworm) - Thursday, 07 December 2017, 19:02 GMT
Task Type General Gripe
Category Packages
Status Closed
Assigned To Christian Hesse (eworm)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Wrong dependencies are specified for libmicrohttpd: 'curl' and 'file'.
Those dependencies add nothing for run-time functionality.
libcurl could be used for testing and could be added to 'checkdepends', but PKGBUILD currently have no 'check()' for libmicrohttpd.

Patch is attached.
   0003-libmicrohttpd-removed-wr... (1.3 KiB)
This task depends upon

Closed by  Christian Hesse (eworm)
Thursday, 07 December 2017, 19:02 GMT
Reason for closing:  Fixed
Additional comments about closing:  libmicrohttpd-0.9.58-1
Comment by Christian Hesse (eworm) - Tuesday, 05 December 2017, 21:45 GMT
Possibly we should go the other way round and enable the checks?

This fails, though...

[...]
SKIP: test_tls_options
PASS: test_https_get_select
PASS: test_https_multi_daemon
FAIL: test_https_get
PASS: test_https_sni
SKIP: test_https_get_parallel_threads
SKIP: test_https_session_info
PASS: test_tls_authentication
PASS: test_https_get_parallel
PASS: test_empty_response
PASS: test_https_time_out
============================================================================
Testsuite summary for GNU Libmicrohttpd 0.9.57
============================================================================
# TOTAL: 11
# PASS: 7
# SKIP: 3
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
   checkdeps.patch (0.7 KiB)
Comment by Evgeny Grin (Karlson2k) - Wednesday, 06 December 2017, 10:24 GMT
How could I precisely reproduce build environment?
I have no single failure on CentOS 5.11, 6.9, 7.4 and Fedora 25, 26, Rawhide.

Patch for tests looks correct.
Comment by Christian Hesse (eworm) - Wednesday, 06 December 2017, 14:27 GMT
The offending call is:

test_cipher_option (NULL, des_cbc3_sha_tlsv1, CURL_SSLVERSION_TLSv1);

at src/testcurl/https/test_https_get.c line 162. This is with current gnutls 3.5.16 from [core].
Comment by Evgeny Grin (Karlson2k) - Thursday, 07 December 2017, 13:45 GMT
Looks like GnuTLS is build on Arch with disabled 3DES.
Anyway, I disabled 3DES usage in MHD tests as it considered to be "unsafe" and could be disabled on other platforms as well.
Tests are fixed in upstream git master, we will consider bugfix release.
Comment by Christian Hesse (eworm) - Thursday, 07 December 2017, 13:56 GMT
'make check' is happy now, thanks! I will add the changes with next release.
Comment by Evgeny Grin (Karlson2k) - Thursday, 07 December 2017, 18:50 GMT
You could add those changes with v0.9.58
Comment by Christian Hesse (eworm) - Thursday, 07 December 2017, 19:01 GMT
Thanks a lot!

Loading...