FS#56585 - [extundelete] didn't work! always got Segmentation Fault

Attached to Project: Community Packages
Opened by john_clare (jusss) - Tuesday, 05 December 2017, 10:53 GMT
Last edited by Jaroslav Lichtblau (Dragonlord) - Sunday, 13 September 2020, 14:23 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jaroslav Lichtblau (Dragonlord)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

I use extundelete to recover my deleted files, and it always got "Loading journal descriptors ... Segmentation fault"

[john@moon ~]$ sudo mount /dev/sda5 /bla2/
[john@moon ~]$ ls -i /bla2/
12 my-zzz 169 '#1048578#' 786433 del-test 1703937 test
[john@moon ~]$ sudo rm /bla2/my-zzz
[john@moon ~]$ sudo umount /bla2
[john@moon ~]$ sudo extundelete /dev/sda5 --restore-inode 12
NOTICE: Extended attributes are not restored.
Loading filesystem metadata ... 400 groups loaded.
Loading journal descriptors ... Segmentation fault

Additional info:
* package version(s)
Repository : community
Name : extundelete
Version : 0.2.4-3
Description : Utility for recovering deleted files from ext2, ext3 or ext4
partitions by parsing the journal
Architecture : x86_64
URL : http://extundelete.sourceforge.net
Licenses : GPL
Groups : None
Provides : None
Depends On : None
Optional Deps : None
Conflicts With : None
Replaces : None
Download Size : 43.60 KiB
Installed Size : 120.00 KiB
Packager : Bartłomiej Piotrowski <bpiotrowski@archlinux.org>
Build Date : Sat 05 Dec 2015 11:19:15 PM CST
Validated By : MD5 Sum SHA-256 Sum Signature


* config and/or log files etc.


Steps to reproduce:
This task depends upon

Closed by  Jaroslav Lichtblau (Dragonlord)
Sunday, 13 September 2020, 14:23 GMT
Reason for closing:  Implemented
Additional comments about closing:  extundelete deleted
Comment by Jaroslav Lichtblau (Dragonlord) - Tuesday, 05 December 2017, 19:30 GMT
Yep, I see unfortunately the same error on my system too. Rebuilding the package does not make any difference.
I'd suggest reporting the issue upstream, but as the project seems fairly dead, not sure if that would lead to a proper fix.
It also seems that others have seen similar trouble: https://sourceforge.net/p/extundelete/mailman/extundelete-users/?viewmonth=201710&viewday=7
Unfortuantely I wasn't able to find any patches or fixes online.
Comment by Jaroslav Lichtblau (Dragonlord) - Friday, 15 December 2017, 20:25 GMT
My plan is to drop extundelete from the [community] repo, unless there is a fix to this issue.
I'm unable to fix this myself.
Comment by john_clare (jusss) - Saturday, 16 December 2017, 09:05 GMT
I saw it works on Fedora, they must have a patch for it, I think we should search for it, I don't know if we can ask for it from Fedora developers
Comment by Jaroslav Lichtblau (Dragonlord) - Monday, 22 January 2018, 17:57 GMT
I see no extra patches or any other magic on Fedora either
https://src.fedoraproject.org/rpms/extundelete/tree/master
Comment by Lev Velykoivanenko (AbysmalBiscuit) - Wednesday, 04 April 2018, 13:08 GMT
The segmentation fault comes from the e2fsprogs library/package being too recent.
From downgrading e2fsprogs I have found that the most recent version that extundelete works with is e2fsprogs-1.42.12-2-x86_64.
Once you upgrade to e2fsprogs-1.42.13-1-x86_64, extundelete will no longer work.

I have forked extundelete and will try to update the project to make it compatible with the latest e2fsprogs, but for now extundelete will remain broken unless people are willing to downgrade their e2fsprogs or someone writes a patch.

My fork can be found here: https://github.com/AbysmalBiscuit/ExtundeleteX
Comment by Lev Velykoivanenko (AbysmalBiscuit) - Saturday, 21 April 2018, 13:27 GMT
Edit 2: both extundelete and extundeletex seem to work and not work sporadically and I haven't yet figured out why.
Comment by Simon (Sbr) - Tuesday, 14 April 2020, 19:36 GMT
The bug is still not fixed. Also I get different errors (sometime segfault, sometimes malloc errors)
Probably this should be removed from the repo?
Comment by Jaroslav Lichtblau (Dragonlord) - Thursday, 10 September 2020, 15:04 GMT

Loading...