FS#56387 - [firefox] Fix mouse gestures on Firefox 57+ (Patch Inside)

Attached to Project: Arch Linux
Opened by Albert Wesker (NeV3rKilL) - Monday, 20 November 2017, 09:15 GMT
Last edited by Jan Alexander Steffens (heftig) - Tuesday, 21 November 2017, 11:45 GMT
Task Type Feature Request
Category Upstream Bugs
Status Closed
Assigned To Jan de Groot (JGC)
Jan Alexander Steffens (heftig)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 6
Private No

Details

Description:

- The GNU/Linux standard behaviour is to show context menu on-press right click mouse. This prevents all Mouse Gestures Addons from work on this system.

- For Firefox <=56, Gestures Addons created a workaround to enable right click accessing to the input devices and requesting for a double click to show the context menu.

- Starting with Firefox >=57, only WebExtension Addons are compatible with the browser. Firefox prevents the WebExtension Addons from accessing to the input devices so workaround to enable right click mouse gestures don't work anymore.

- A discussion has been created on https://bugzilla.mozilla.org/show_bug.cgi?id=1360278 to solve this issue and patches have been created, tested and even approved for SUSE Distribution to be included on its official package https://build.opensuse.org/request/show/542056 .

- Mozilla didn't show enough interest on work on this bug, and even if they include the patch right now into nightly, we would have to wait at least 5 months to complete the Mozilla release cycle for the patch to hit Firefox stable.

Request:

- Apply patch https://bugzilla.mozilla.org/attachment.cgi?id=8919045&action=view to the current extra/firefox package in order to be able to enable Mouse Gestures Addons on Firefox again.

-- This patch generates a new variable accessed from about:config in order to change the behaviour of the context menu and switch to show the context menu onPress/onRelease button.
This task depends upon

Closed by  Jan Alexander Steffens (heftig)
Tuesday, 21 November 2017, 11:45 GMT
Reason for closing:  Fixed
Additional comments about closing:  57.0-2
Comment by Jay (GSF1200S) - Monday, 20 November 2017, 14:57 GMT
Just to be clear, this patch creates an about:config value that defaults to false- the impact on normal users is literally nothing. It only comes into play if a user switches the boolean to true, and at that point the context menu spawns on right click release. Arch's desire to avoid patching for the purpose of encouraging upstream fixes isn't really in play here since upstream already has a bug report, a working patch (for Linux- Mac OS is still in limbo), and already plans to merge the changes. For those using Mouse Gestures, they would either have to deal with 5 months of double right clicking to show the context menu for working mouse gestures (and only for the few add-ons which offer this alternative), or would have to deal with recompiling Firefox with the patch every single time any release is made for the next 5 months (at the earliest).
Comment by Jan Alexander Steffens (heftig) - Monday, 20 November 2017, 15:14 GMT
I'll consider backporting a patch once it hits mozilla-central.
Comment by Eli Schwartz (eschwartz) - Monday, 20 November 2017, 16:28 GMT
> Arch's desire to avoid patching for the purpose of encouraging upstream fixes

This is not entirely true, as heftig said Arch is usually willing to *backport* patches that have been accepted upstream, as long as a decent rationale for doing so rather than just waiting can be made.

(Backports mean both that the fix has been pushed upstream, and that the people who really understand the codebase are sure there are no ill effects.)
Comment by Albert Wesker (NeV3rKilL) - Tuesday, 21 November 2017, 10:07 GMT
The patch has been reviewed and accepted upstream. I think we are ready for backporting now.

New Patch
https://bugzilla.mozilla.org/attachment.cgi?id=8930206

Bugzilla
https://bugzilla.mozilla.org/show_bug.cgi?id=1360278

Loading...