FS#56355 - [syslog-ng] missing /etc/default file for templated service file
Attached to Project:
Arch Linux
Opened by Geert Hendrickx (ghen) - Thursday, 16 November 2017, 20:07 GMT
Last edited by Antonio Rojas (arojas) - Sunday, 19 November 2017, 22:34 GMT
Opened by Geert Hendrickx (ghen) - Thursday, 16 November 2017, 20:07 GMT
Last edited by Antonio Rojas (arojas) - Sunday, 19 November 2017, 22:34 GMT
|
Details
Description:
Since 3.12.1 upgrade, an existing system with working syslog-ng will no longer work. Because the systemd unit file is now templated, it requires two actions from the user: 1) create an /etc/default/syslog-ng@default environment file with explicit settings that used to be implicit defaults (this file should be included in the package?) 2) systemctl disable syslog-ng ; systemctl daemon-reload ; systemctl enable syslog-ng@default The update makes no mention whatsoever and leaves users with a broken system. See also https://bbs.archlinux.org/viewtopic.php?pid=1749617 |
This task depends upon
Closed by Antonio Rojas (arojas)
Sunday, 19 November 2017, 22:34 GMT
Reason for closing: Fixed
Additional comments about closing: syslog-ng 3.12.1-5
Sunday, 19 November 2017, 22:34 GMT
Reason for closing: Fixed
Additional comments about closing: syslog-ng 3.12.1-5
https://github.com/balabit/syslog-ng/blob/649d1151e79033cc2b81b3353917507266814436/contrib/systemd/syslog-ng%40default
CONFIG_FILE=/etc/syslog-ng/syslog-ng.conf
PERSIST_FILE=/var/lib/syslog-ng/syslog-ng.persist
CONTROL_FILE=/run/syslog-ng.ctl
PID_FILE=/var/run/syslog-ng.pid
OTHER_OPTIONS="--enable-core"
At the very least, a default /etc/default config file should be included in any packaging of this version of syslog-ng.
It would be appropriate to immediately add explanations of the /etc/default config file and instance name to the archwiki syslog-ng page.
Additionally and even though one might differ on whether this is an upstream or a packaging issue: As 'The main functionality of the application does not work [...]' (bug reporting guidelines) I don't think 'Low' is an appropriate severity.
OP: Maybe for packaging it would work to use the old service file for upgrades from pre v3.12, leave it as it is on the system within v3.12.1 upgrades and figure out a way to move to the multiple instance configuration graciously for the next upstream release? Just a thought.
I don;t mind if something changes from one package version to the next - I think everyone kinda expects it from time to time - but PLEASE document it (again, a generic shout-out).
Perhaps it would be best to leave the change as is and have the man page updated upstream. If a default template file is included in /etc/default or even just listed out on the man page, as long as it's documented, that would settle the issue, IMO.
Maybe patch a syslog-ng@default.sample file into the /etc/syslog-ng directory... that would be pretty innocuous. Just put a comment at the top of the file that says where the file should go.
refers to an invalid path (on Arch), defaults file must be patched to CONFIG_FILE=/etc/syslog-ng/syslog-ng.conf prior to installation.
Also CONTROL_FILE=/run/syslog-ng.ctl for compatibility with previous default location.